From f2f393f086af0bbada59f948d79352cd41b46acb Mon Sep 17 00:00:00 2001 From: Christoph Purrer Date: Mon, 26 Oct 2026 07:50:44 -0700 Subject: [PATCH] Bridgeless-context ReactImagePropertyTest (#59253) Summary: Pull Request resolved: https://github.com/react/react-native/pull/59253 Replace the deprecated `BridgeReactContext` + mock `CatalystInstance` setup with `createTestReactApplicationContext`, stub feature flags before creating the context, and add the `ShadowSoLoader` Robolectric shadow. Changelog: [Internal] Reviewed By: javache Differential Revision: D126543660 fbshipit-source-id: 870e12d530cdb38d940e45b2bf2d723b57719098 --- .../views/image/ReactImagePropertyTest.kt | 22 ++++++------------- 1 file changed, 7 insertions(+), 15 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.kt b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.kt index b69f015595e..15913bccfb4 100644 --- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.kt +++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/views/image/ReactImagePropertyTest.kt @@ -5,10 +5,6 @@ * LICENSE file in the root directory of this source tree. */ -// TODO T207169925: Migrate CatalystInstance to Reacthost and remove the Suppress("DEPRECATION") -// annotation -@file:Suppress("DEPRECATION") - package com.facebook.react.views.image import android.graphics.Color @@ -19,10 +15,9 @@ import com.facebook.drawee.backends.pipeline.PipelineDraweeControllerBuilder import com.facebook.drawee.drawable.ScalingUtils import com.facebook.imagepipeline.request.ImageRequest import com.facebook.react.bridge.Arguments -import com.facebook.react.bridge.BridgeReactContext -import com.facebook.react.bridge.CatalystInstance import com.facebook.react.bridge.JavaOnlyMap -import com.facebook.react.bridge.ReactTestHelper.createMockCatalystInstance +import com.facebook.react.bridge.ReactApplicationContext +import com.facebook.react.bridge.ReactTestHelper.createTestReactApplicationContext import com.facebook.react.common.ReactConstants import com.facebook.react.internal.featureflags.ReactNativeFeatureFlagsForTests import com.facebook.react.modules.fresco.ReactNetworkImageRequest @@ -37,6 +32,7 @@ import com.facebook.react.util.RNLog import com.facebook.react.views.imagehelper.ImageSource import com.facebook.soloader.SoLoader import com.facebook.testutils.shadows.ShadowArguments +import com.facebook.testutils.shadows.ShadowSoLoader import org.assertj.core.api.Assertions.assertThat import org.junit.After import org.junit.Before @@ -61,18 +57,18 @@ import org.robolectric.annotation.Config * Verify that [com.facebook.drawee.drawable.ScalingUtils] properties are being applied correctly by * [ReactImageManager]. */ -@Config(shadows = [ShadowArguments::class]) +@Config(shadows = [ShadowArguments::class, ShadowSoLoader::class]) @RunWith(RobolectricTestRunner::class) class ReactImagePropertyTest { - private lateinit var context: BridgeReactContext - private lateinit var catalystInstanceMock: CatalystInstance + private lateinit var context: ReactApplicationContext private lateinit var themeContext: ThemedReactContext private lateinit var rnLog: MockedStatic private lateinit var flogMock: MockedStatic @Before fun setup() { + ReactNativeFeatureFlagsForTests.setUp() rnLog = mockStatic(RNLog::class.java) rnLog.`when` { RNLog.w(any(), anyString()) }.thenAnswer {} @@ -80,14 +76,10 @@ class ReactImagePropertyTest { flogMock = mockStatic(FLog::class.java) SoLoader.setInTestMode() - context = BridgeReactContext(RuntimeEnvironment.getApplication()) - catalystInstanceMock = createMockCatalystInstance() - context.initializeWithInstance(catalystInstanceMock) + context = createTestReactApplicationContext(RuntimeEnvironment.getApplication()) themeContext = ThemedReactContext(context, context, null, -1) Fresco.initialize(context) DisplayMetricsHolder.setScreenDisplayMetrics(DisplayMetrics()) - - ReactNativeFeatureFlagsForTests.setUp() } @After