From f2d3113c1db894097ef67ab1da84a508e39a3448 Mon Sep 17 00:00:00 2001 From: Andy Street Date: Wed, 2 Nov 2016 10:43:53 -0700 Subject: [PATCH] Fix bug where ScrollView would stop overscrolled by a bit on fling Summary: This bug was introduced with the bounce-back bug fix. We need to actually set the scroll position to the max scroll position if we've gone over otherwise it can get stuck. Reviewed By: lexs Differential Revision: D4118084 fbshipit-source-id: 41a927a40000c526414096c9385f8bd3cbd907f3 --- .../java/com/facebook/react/views/scroll/ReactScrollView.java | 1 + 1 file changed, 1 insertion(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java b/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java index 31ff032e804..86bfc939046 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/scroll/ReactScrollView.java @@ -332,6 +332,7 @@ public class ReactScrollView extends ScrollView implements ReactClippingViewGrou getChildAt(0).getHeight() - (getHeight() - getPaddingBottom() - getPaddingTop())); if (scrollY >= scrollRange) { mScroller.abortAnimation(); + scrollY = scrollRange; } }