From f25abe51ce93b97ef1fe97af5fc76f13a5a6ff03 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Thu, 10 Oct 2024 11:32:37 -0700 Subject: [PATCH] Remove Deprecated DefaultDevSupportManagerFactory.create() (#46959) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46959 This method was deprecated in: b8893c7003218362d5fbea23a949621eb1f5de54 since React Native 0.72. I verified that no-one is using it in OSS so I'm removing it. This is necessary as I'll need to refactor the BridgelessDevSupportManager a bit. Changelog: [Android] [Breaking] - Remove Deprecated DefaultDevSupportManagerFactory.create() Reviewed By: javache Differential Revision: D64184635 fbshipit-source-id: a4081b2189d2e22cd9b2067f982a6ffd4f8b054e --- .../ReactAndroid/api/ReactAndroid.api | 1 - .../DefaultDevSupportManagerFactory.kt | 25 ------------------- 2 files changed, 26 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index 219262432d6..5ee3c02d7af 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -2133,7 +2133,6 @@ public final class com/facebook/react/devsupport/DefaultDevLoadingViewImplementa public final class com/facebook/react/devsupport/DefaultDevSupportManagerFactory : com/facebook/react/devsupport/DevSupportManagerFactory { public fun ()V - public final fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZI)Lcom/facebook/react/devsupport/interfaces/DevSupportManager; public fun create (Landroid/content/Context;Lcom/facebook/react/devsupport/ReactInstanceDevHelper;Ljava/lang/String;ZLcom/facebook/react/devsupport/interfaces/RedBoxHandler;Lcom/facebook/react/devsupport/interfaces/DevBundleDownloadListener;ILjava/util/Map;Lcom/facebook/react/common/SurfaceDelegateFactory;Lcom/facebook/react/devsupport/interfaces/DevLoadingViewManager;Lcom/facebook/react/devsupport/interfaces/PausedInDebuggerOverlayManager;)Lcom/facebook/react/devsupport/interfaces/DevSupportManager; } diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt index ac7d5daabe8..9ca3b860bf4 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DefaultDevSupportManagerFactory.kt @@ -23,31 +23,6 @@ import com.facebook.react.packagerconnection.RequestHandler */ public class DefaultDevSupportManagerFactory : DevSupportManagerFactory { - @Deprecated( - "in favor of the customisable create for DevSupportManagerFactory", - ReplaceWith( - "create(applicationContext, reactInstanceManagerHelper, packagerPathForJSBundleName, enableOnCreate, redBoxHandler, devBundleDownloadListener, minNumShakes, customPackagerCommandHandlers, surfaceDelegateFactory, devLoadingViewManager, pausedInDebuggerOverlayManager)")) - public fun create( - applicationContext: Context, - reactInstanceDevHelper: ReactInstanceDevHelper, - packagerPathForJSBundleName: String?, - enableOnCreate: Boolean, - minNumShakes: Int - ): DevSupportManager { - return create( - applicationContext, - reactInstanceDevHelper, - packagerPathForJSBundleName, - enableOnCreate, - null, - null, - minNumShakes, - null, - null, - null, - null) - } - public override fun create( applicationContext: Context, reactInstanceManagerHelper: ReactInstanceDevHelper,