From f2191ecbc5ed67049ee67665c8e3e82784cf56de Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Wed, 8 Sep 2021 11:52:12 -0700 Subject: [PATCH] Clean up dtors in LayoutAnimations Summary: changelog: [internal] Clean up destructors for classes in LayoutAnimations module. Reviewed By: RSNara Differential Revision: D30728212 fbshipit-source-id: 612afb8ebf1407318d22fc461fcc7e03a2b72c47 --- ReactCommon/react/renderer/animations/LayoutAnimationDriver.h | 2 -- .../react/renderer/animations/LayoutAnimationKeyFrameManager.h | 1 - ReactCommon/react/renderer/mounting/MountingOverrideDelegate.h | 2 +- .../react/renderer/uimanager/UIManagerAnimationDelegate.h | 2 +- 4 files changed, 2 insertions(+), 5 deletions(-) diff --git a/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h b/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h index f40189c252c..c5960fa50d0 100644 --- a/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h +++ b/ReactCommon/react/renderer/animations/LayoutAnimationDriver.h @@ -21,8 +21,6 @@ class LayoutAnimationDriver : public LayoutAnimationKeyFrameManager { LayoutAnimationStatusDelegate *delegate) : LayoutAnimationKeyFrameManager(runtimeExecutor, delegate) {} - virtual ~LayoutAnimationDriver() {} - protected: virtual void animationMutationsForFrame( SurfaceId surfaceId, diff --git a/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h b/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h index 018cb272adf..877c852259e 100644 --- a/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h +++ b/ReactCommon/react/renderer/animations/LayoutAnimationKeyFrameManager.h @@ -50,7 +50,6 @@ class LayoutAnimationKeyFrameManager : public UIManagerAnimationDelegate, .time_since_epoch()) .count(); }) {} - ~LayoutAnimationKeyFrameManager() {} #pragma mark UIManagerAnimationDelegate methods diff --git a/ReactCommon/react/renderer/mounting/MountingOverrideDelegate.h b/ReactCommon/react/renderer/mounting/MountingOverrideDelegate.h index c0c249b8593..5aa95d4d80f 100644 --- a/ReactCommon/react/renderer/mounting/MountingOverrideDelegate.h +++ b/ReactCommon/react/renderer/mounting/MountingOverrideDelegate.h @@ -22,7 +22,7 @@ class MountingCoordinator; class MountingOverrideDelegate { public: virtual bool shouldOverridePullTransaction() const = 0; - virtual ~MountingOverrideDelegate(){}; + virtual ~MountingOverrideDelegate() = default; /** * Delegates that override this method are responsible for: diff --git a/ReactCommon/react/renderer/uimanager/UIManagerAnimationDelegate.h b/ReactCommon/react/renderer/uimanager/UIManagerAnimationDelegate.h index 0aa7ca225cd..dc4417df99a 100644 --- a/ReactCommon/react/renderer/uimanager/UIManagerAnimationDelegate.h +++ b/ReactCommon/react/renderer/uimanager/UIManagerAnimationDelegate.h @@ -16,7 +16,7 @@ namespace facebook::react { class UIManagerAnimationDelegate { public: - virtual ~UIManagerAnimationDelegate(){}; + virtual ~UIManagerAnimationDelegate() = default; /* * Configure a LayoutAnimation.