From f11608da4efc82e1b930434951e573e158d3bbf8 Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Tue, 12 Dec 2023 10:55:32 -0800 Subject: [PATCH] Remove the installArchives task (#41832) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/41832 I'm removing the `installArchives` task and all the setup to publish the Maven Local inside the NPM package as we're not using this entirely and we won't be able to use it anyway (as the Maven Local is too big to fit an NPM package). Changelog: [Internal] [Changed] - Remove the installArchives task Reviewed By: GijsWeterings Differential Revision: D51890224 fbshipit-source-id: 3ffdc67a9fe931118596f6f74a5a2df0313ca3f2 --- build.gradle.kts | 9 -------- .../ReactAndroid/DevExperience.md | 23 ------------------- .../ReactAndroid/build.gradle.kts | 2 -- .../ReactAndroid/hermes-engine/build.gradle | 4 ---- .../react-native/ReactAndroid/publish.gradle | 5 ---- scripts/run-ci-e2e-tests.js | 2 +- 6 files changed, 1 insertion(+), 44 deletions(-) delete mode 100644 packages/react-native/ReactAndroid/DevExperience.md diff --git a/build.gradle.kts b/build.gradle.kts index 3baf29f0595..de043f8d8bb 100644 --- a/build.gradle.kts +++ b/build.gradle.kts @@ -90,15 +90,6 @@ tasks.register("build") { dependsOn(gradle.includedBuild("react-native-gradle-plugin").task(":build")) } -tasks.register("publishAllInsideNpmPackage") { - description = - "Publish all the artifacts to be available inside the NPM package in the `android` folder." - // Due to size constraints of NPM, we publish only react-native and hermes-engine inside - // the NPM package. - dependsOn(":packages:react-native:ReactAndroid:installArchives") - dependsOn(":packages:react-native:ReactAndroid:hermes-engine:installArchives") -} - tasks.register("publishAllToMavenTempLocal") { description = "Publish all the artifacts to be available inside a Maven Local repository on /tmp." dependsOn(":packages:react-native:ReactAndroid:publishAllPublicationsToMavenTempLocalRepository") diff --git a/packages/react-native/ReactAndroid/DevExperience.md b/packages/react-native/ReactAndroid/DevExperience.md deleted file mode 100644 index c0d259daae2..00000000000 --- a/packages/react-native/ReactAndroid/DevExperience.md +++ /dev/null @@ -1,23 +0,0 @@ -Here's how to test the whole dev experience end-to-end. This will be eventually merged into the [Getting Started guide](https://reactnative.dev/docs/getting-started). - -Assuming you have the [Android SDK](https://developer.android.com/sdk/installing/index.html) installed, run `android` to open the Android SDK Manager. - -Make sure you have the following installed: - -- Android SDK version 23 -- SDK build tools version 23 -- Android Support Repository 17 (for Android Support Library) - -Follow steps on https://github.com/react-native-community/cli/blob/master/CONTRIBUTING.md, but be sure to bump the version of react-native in package.json to some version > 0.9 (latest published npm version) or set up proxying properly for react-native - -- From the react-native-android repo: - - `./gradlew :ReactAndroid:installArchives` - - *Assuming you already have android-jsc installed to local maven repo, no steps included here* -- `react-native init ProjectName` -- Open up your Android emulator (Genymotion is recommended) -- `cd ProjectName` -- `react-native run-android` - -In case the app crashed: - -- Run `adb logcat` and try to find a Java exception diff --git a/packages/react-native/ReactAndroid/build.gradle.kts b/packages/react-native/ReactAndroid/build.gradle.kts index e41507c1c79..ee942e0d132 100644 --- a/packages/react-native/ReactAndroid/build.gradle.kts +++ b/packages/react-native/ReactAndroid/build.gradle.kts @@ -454,8 +454,6 @@ val packageReactNdkLibsForBuck by into("src/main/jni/prebuilt/lib") } -val installArchives by tasks.registering { dependsOn("publishAllPublicationsToNpmRepository") } - repositories { // Normally RNGP will set repositories for all modules, // but when consumed from source, we need to re-declare diff --git a/packages/react-native/ReactAndroid/hermes-engine/build.gradle b/packages/react-native/ReactAndroid/hermes-engine/build.gradle index f008a5dd8ab..b18dc847196 100644 --- a/packages/react-native/ReactAndroid/hermes-engine/build.gradle +++ b/packages/react-native/ReactAndroid/hermes-engine/build.gradle @@ -75,10 +75,6 @@ task downloadHermes(type: Download) { dest(new File(downloadsDir, "hermes.tar.gz")) } -task installArchives { - dependsOn("publishAllPublicationsToNpmRepository") -} - task unzipHermes(dependsOn: downloadHermes, type: Copy) { from(tarTree(downloadHermes.dest)) { eachFile { file -> diff --git a/packages/react-native/ReactAndroid/publish.gradle b/packages/react-native/ReactAndroid/publish.gradle index b249f48ffdc..32287a7c813 100644 --- a/packages/react-native/ReactAndroid/publish.gradle +++ b/packages/react-native/ReactAndroid/publish.gradle @@ -13,7 +13,6 @@ def signingKey = findProperty("SIGNING_KEY") def signingPwd = findProperty("SIGNING_PWD") def reactAndroidProjectDir = project(':packages:react-native:ReactAndroid').projectDir -def androidOutputUrl = "file://${reactAndroidProjectDir}/../android" def mavenTempLocalUrl = "file:///tmp/maven-local" publishing { @@ -65,10 +64,6 @@ publishing { } repositories { - maven { - name = "npm" - url = androidOutputUrl - } maven { name = "mavenTempLocal" url = mavenTempLocalUrl diff --git a/scripts/run-ci-e2e-tests.js b/scripts/run-ci-e2e-tests.js index 7c28b4c6f3c..d8c7e0a07c9 100644 --- a/scripts/run-ci-e2e-tests.js +++ b/scripts/run-ci-e2e-tests.js @@ -53,7 +53,7 @@ try { describe('Compile Android binaries'); if ( exec( - './gradlew :ReactAndroid:installArchives -Pjobs=1 -Dorg.gradle.jvmargs="-Xmx512m -XX:+HeapDumpOnOutOfMemoryError"', + './gradlew publishAllToMavenTempLocal -Pjobs=1 -Dorg.gradle.jvmargs="-Xmx512m -XX:+HeapDumpOnOutOfMemoryError"', ).code ) { echo('Failed to compile Android binaries');