From f088bca580032b79caaebebd5ab59f2540439c8f Mon Sep 17 00:00:00 2001 From: cailenmusselman Date: Wed, 10 May 2017 05:14:55 -0700 Subject: [PATCH] ProgressBarAndroid checks indeterminate prop type manually Summary: Causes a YellowBox warning: "You are manually calling a React.PropTypes validation function for 'indeterminate' prop on 'ProgressBarAndroid'." Initially reported here: https://github.com/facebook/react-native/issues/9692 but closed by the creator because he switched to using ActivityIndicator. Fixed as per the guidelines here: https://facebook.github.io/react/warnings/dont-call-proptypes.html ``` /** * Sample React Native App * https://github.com/facebook/react-native * flow */ import React, { Component } from 'react'; import { AppRegistry, StyleSheet, View, ProgressBarAndroid } from 'react-native'; export default class AwesomeProject extends Component { render() { return ( ); } } const styles = StyleSheet.create({ container: { flex: 1 } }); AppRegistry.registerComponent('AwesomeProject', () => AwesomeProject); ``` Closes https://github.com/facebook/react-native/pull/11791 Differential Revision: D4998602 Pulled By: davidaurelio fbshipit-source-id: e210684e2f2497238e4d3d0adf2754075be81e98 --- .../ProgressBarAndroid/ProgressBarAndroid.android.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.android.js b/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.android.js index e3b0b6ee7ae..25b43b047c9 100644 --- a/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.android.js +++ b/Libraries/Components/ProgressBarAndroid/ProgressBarAndroid.android.js @@ -28,7 +28,7 @@ var STYLE_ATTRIBUTES = [ 'LargeInverse', ]; -var indeterminateType = function(props, propName, componentName) { +var indeterminateType = function(props, propName, componentName, ...rest) { var checker = function() { var indeterminate = props[propName]; var styleAttr = props.styleAttr; @@ -37,7 +37,7 @@ var indeterminateType = function(props, propName, componentName) { } }; - return PropTypes.bool(props, propName, componentName) || checker(); + return PropTypes.bool(props, propName, componentName, ...rest) || checker(); }; /**