From ee4e2ae48932859f02acb8eb338d118d32c1716b Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 11 Oct 2018 23:01:57 -0700 Subject: [PATCH] Fix AttributeStrings tests Summary: This diff fixes AttributeStrings tests Reviewed By: shergin Differential Revision: D10349107 fbshipit-source-id: c03407bf057535ebbb75ccf02d03f76fbc3cd360 --- ReactCommon/fabric/attributedstring/conversions.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ReactCommon/fabric/attributedstring/conversions.h b/ReactCommon/fabric/attributedstring/conversions.h index 6bb6b189342..c30a4e2879b 100644 --- a/ReactCommon/fabric/attributedstring/conversions.h +++ b/ReactCommon/fabric/attributedstring/conversions.h @@ -478,7 +478,9 @@ inline folly::dynamic toDynamic(const AttributedString &attributedString) { for (auto fragment : attributedString.getFragments()) { folly::dynamic dynamicFragment = folly::dynamic::object(); dynamicFragment["string"] = fragment.string; - dynamicFragment["reactTag"] = fragment.parentShadowNode->getTag(); + if (fragment.parentShadowNode) { + dynamicFragment["reactTag"] = fragment.parentShadowNode->getTag(); + } dynamicFragment["textAttributes"] = toDynamic(fragment.textAttributes); fragments.push_back(dynamicFragment); }