From ee245b9be8e05b6e2a37b2771bd1b2d9e00ad16d Mon Sep 17 00:00:00 2001 From: "Andrew Y. Chen" Date: Tue, 21 Mar 2017 14:45:37 -0700 Subject: [PATCH] Fix instrumentation tests for api 22 Summary: Bug in Android https://code.google.com/p/android/issues/detail?id=33868 causes the RN catalyst instrumentation test to fail with ``` java.lang.ArrayIndexOutOfBoundsException: length=253; index=-1 at android.text.StaticLayout.calculateEllipsis(StaticLayout.java:667) at android.text.StaticLayout.out(StaticLayout.java:631) at android.text.StaticLayout.generate(StaticLayout.java:423) ... ``` The fix is to set singleLine to true when there is only one line of text Reviewed By: AaaChiuuu Differential Revision: D4562000 fbshipit-source-id: 84248e3982063b767e8b0465effe2321b54a7fa2 --- .../main/java/com/facebook/react/views/text/ReactTextView.java | 1 + 1 file changed, 1 insertion(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java index 3d5d9668bd8..fa8f87710b1 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java +++ b/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java @@ -231,6 +231,7 @@ public class ReactTextView extends TextView implements ReactCompoundView { public void setNumberOfLines(int numberOfLines) { mNumberOfLines = numberOfLines == 0 ? ViewDefaults.NUMBER_OF_LINES : numberOfLines; + setSingleLine(mNumberOfLines == 1); setMaxLines(mNumberOfLines); }