From ed63646fc271a7846df3e2d8240bd658c5f33144 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Rub=C3=A9n=20Norte?= Date: Fri, 2 Aug 2024 10:19:49 -0700 Subject: [PATCH] Move ErrorHandlers to react-native/src/private (#45876) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/45876 Changelog: [internal] Reviewed By: dmytrorykun Differential Revision: D60597776 fbshipit-source-id: 1093aee0f2b84312b55a2b0c22e2b1576c60e26e --- .../ReactNative/RendererImplementation.js | 2 +- .../__snapshots__/public-api-test.js.snap | 20 ------------------- .../renderer/errorhandling}/ErrorHandlers.js | 9 +++++---- 3 files changed, 6 insertions(+), 25 deletions(-) rename packages/react-native/{Libraries/Core => src/private/renderer/errorhandling}/ErrorHandlers.js (95%) diff --git a/packages/react-native/Libraries/ReactNative/RendererImplementation.js b/packages/react-native/Libraries/ReactNative/RendererImplementation.js index 7a9faac5ac7..ee250eb783c 100644 --- a/packages/react-native/Libraries/ReactNative/RendererImplementation.js +++ b/packages/react-native/Libraries/ReactNative/RendererImplementation.js @@ -20,7 +20,7 @@ import { onCaughtError, onRecoverableError, onUncaughtError, -} from '../Core/ErrorHandlers'; +} from '../../src/private/renderer/errorhandling/ErrorHandlers'; import {type RootTag} from './RootTag'; export function renderElement({ element, diff --git a/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap b/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap index 480504c75d9..dc58d59d1bd 100644 --- a/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap +++ b/packages/react-native/Libraries/__tests__/__snapshots__/public-api-test.js.snap @@ -4287,26 +4287,6 @@ declare module.exports: symbolicateStackTrace; " `; -exports[`public API should not change unintentionally Libraries/Core/ErrorHandlers.js 1`] = ` -"type ErrorInfo = { - +componentStack?: ?string, - +errorBoundary?: ?React$Component, -}; -declare export function onUncaughtError( - errorValue: mixed, - errorInfo: ErrorInfo -): void; -declare export function onCaughtError( - errorValue: mixed, - errorInfo: ErrorInfo -): void; -declare export function onRecoverableError( - errorValue: mixed, - errorInfo: ErrorInfo -): void; -" -`; - exports[`public API should not change unintentionally Libraries/Core/ExceptionsManager.js 1`] = ` "declare class SyntheticError extends Error { name: string; diff --git a/packages/react-native/Libraries/Core/ErrorHandlers.js b/packages/react-native/src/private/renderer/errorhandling/ErrorHandlers.js similarity index 95% rename from packages/react-native/Libraries/Core/ErrorHandlers.js rename to packages/react-native/src/private/renderer/errorhandling/ErrorHandlers.js index e98246970ac..39b91617354 100644 --- a/packages/react-native/Libraries/Core/ErrorHandlers.js +++ b/packages/react-native/src/private/renderer/errorhandling/ErrorHandlers.js @@ -8,11 +8,12 @@ * @flow strict */ -'use strict'; +import type {ExtendedError} from '../../../../Libraries/Core/ExtendedError'; -import type {ExtendedError} from './ExtendedError'; - -import {SyntheticError, handleException} from './ExceptionsManager'; +import { + SyntheticError, + handleException, +} from '../../../../Libraries/Core/ExceptionsManager'; type ErrorInfo = { +componentStack?: ?string,