From ed3f2f40e1612b63c679d2a067c6786e56bb44d0 Mon Sep 17 00:00:00 2001 From: Joe Vilches Date: Tue, 21 May 2024 14:04:01 -0700 Subject: [PATCH] Fix small props parsing bug for filter (#44637) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/44637 Setting the wrong thing to {}. `result` should be set here just like in the other early returns. Changelog: [Internal] Reviewed By: NickGerleman Differential Revision: D57617046 fbshipit-source-id: e47dbdb7821879ffa02d11b7e68eec1c9bfbdefd --- .../ReactCommon/react/renderer/components/view/conversions.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/react/renderer/components/view/conversions.h b/packages/react-native/ReactCommon/react/renderer/components/view/conversions.h index 460528ef0c8..fa050426948 100644 --- a/packages/react-native/ReactCommon/react/renderer/components/view/conversions.h +++ b/packages/react-native/ReactCommon/react/renderer/components/view/conversions.h @@ -833,7 +833,7 @@ inline void fromRawValue( filter.push_back(filterPrimitive); } catch (const std::exception& e) { LOG(ERROR) << "Could not parse FilterPrimitive: " << e.what(); - filter = {}; + result = {}; return; } }