From ed3eacb8b954cc4b594d4d667f49f0695b34a7aa Mon Sep 17 00:00:00 2001 From: David Vacca Date: Fri, 23 Feb 2024 02:42:20 -0800 Subject: [PATCH] Mark classes of package uimanager as @Nullsafe (#43155) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43155 All these classes are NullSafe, let's mark them as NullSafe(Local) to ensure lint detect errors in the future changelog: [internal] internal Reviewed By: arushikesarwani94 Differential Revision: D54027178 fbshipit-source-id: 37940ecec4d42f9f5ae7784a865564b0ef80f4a7 --- .../facebook/react/uimanager/ComponentNameResolverManager.java | 2 ++ .../com/facebook/react/uimanager/FabricViewStateManager.java | 2 ++ .../src/main/java/com/facebook/react/uimanager/FloatUtil.java | 3 +++ 3 files changed, 7 insertions(+) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolverManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolverManager.java index 75463b8c43b..ac97b95c3c7 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolverManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/ComponentNameResolverManager.java @@ -7,12 +7,14 @@ package com.facebook.react.uimanager; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.jni.HybridData; import com.facebook.proguard.annotations.DoNotStrip; import com.facebook.proguard.annotations.DoNotStripAny; import com.facebook.react.bridge.RuntimeExecutor; import com.facebook.soloader.SoLoader; +@Nullsafe(Nullsafe.Mode.LOCAL) @DoNotStripAny public class ComponentNameResolverManager { diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FabricViewStateManager.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FabricViewStateManager.java index 02ea431f7f4..6792a8cb9c7 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FabricViewStateManager.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FabricViewStateManager.java @@ -9,6 +9,7 @@ package com.facebook.react.uimanager; import androidx.annotation.Nullable; import com.facebook.common.logging.FLog; +import com.facebook.infer.annotation.Nullsafe; import com.facebook.react.bridge.ReadableMap; import com.facebook.react.bridge.WritableMap; @@ -24,6 +25,7 @@ import com.facebook.react.bridge.WritableMap; * retrying the UpdateState call until it succeeds; or you call setState again; or the View layer is * updated with a newer StateWrapper. */ +@Nullsafe(Nullsafe.Mode.LOCAL) @Deprecated( since = "Deprecated class since v0.73.0, please use com.facebook.react.uimanager.StateWrapper instead.", diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FloatUtil.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FloatUtil.java index 94add5350e3..1d1a5d56a56 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FloatUtil.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/uimanager/FloatUtil.java @@ -7,6 +7,9 @@ package com.facebook.react.uimanager; +import com.facebook.infer.annotation.Nullsafe; + +@Nullsafe(Nullsafe.Mode.LOCAL) public class FloatUtil { private static final float EPSILON = .00001f;