From eca4d76d81efa53316cd36fffb97cee8ed206fb1 Mon Sep 17 00:00:00 2001 From: Pieter De Baets Date: Thu, 14 Mar 2024 10:31:37 -0700 Subject: [PATCH] Rollout enableBridgelessArchitectureSoftExceptions (#43485) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/43485 Already fully rolled out internally. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D54804177 fbshipit-source-id: 128822d408b6943f1f1536eb0101c6684cd45106 --- .../ReactAndroid/api/ReactAndroid.api | 1 - .../facebook/react/config/ReactFeatureFlags.java | 5 ----- .../com/facebook/react/runtime/ReactHostImpl.java | 15 ++++++--------- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api index a899e813010..d43f2379183 100644 --- a/packages/react-native/ReactAndroid/api/ReactAndroid.api +++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api @@ -1909,7 +1909,6 @@ public class com/facebook/react/config/ReactFeatureFlags { public static field dispatchPointerEvents Z public static field enableBridgelessArchitecture Z public static field enableBridgelessArchitectureNewCreateReloadDestroy Z - public static field enableBridgelessArchitectureSoftExceptions Z public static field enableClonelessStateProgression Z public static field enableCppPropsIteratorSetter Z public static field enableEagerRootViewAttachment Z diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java index 9c5a562404d..7809333d8e4 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java @@ -66,11 +66,6 @@ public class ReactFeatureFlags { */ public static boolean enableBridgelessArchitecture = false; - /** - * Does the bridgeless architecture log soft exceptions. Could be useful for tracking down issues. - */ - public static volatile boolean enableBridgelessArchitectureSoftExceptions = false; - /** Does the bridgeless architecture use the new create/reload/destroy routines */ public static volatile boolean enableBridgelessArchitectureNewCreateReloadDestroy = true; diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java index 95fcac63cc5..c98603e9b50 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/runtime/ReactHostImpl.java @@ -48,7 +48,6 @@ import com.facebook.react.bridge.queue.QueueThreadExceptionHandler; import com.facebook.react.bridge.queue.ReactQueueConfiguration; import com.facebook.react.common.LifecycleState; import com.facebook.react.common.build.ReactBuildConfig; -import com.facebook.react.config.ReactFeatureFlags; import com.facebook.react.devsupport.DevSupportManagerBase; import com.facebook.react.devsupport.DisabledDevSupportManager; import com.facebook.react.devsupport.InspectorFlags; @@ -879,16 +878,14 @@ public class ReactHostImpl implements ReactHost { private void raiseSoftException(String method, String message, @Nullable Throwable throwable) { log(method, message); - if (ReactFeatureFlags.enableBridgelessArchitectureSoftExceptions) { - if (throwable != null) { - ReactSoftExceptionLogger.logSoftException( - TAG, new ReactNoCrashSoftException(method + ": " + message, throwable)); - return; - } - + if (throwable != null) { ReactSoftExceptionLogger.logSoftException( - TAG, new ReactNoCrashSoftException(method + ": " + message)); + TAG, new ReactNoCrashSoftException(method + ": " + message, throwable)); + return; } + + ReactSoftExceptionLogger.logSoftException( + TAG, new ReactNoCrashSoftException(method + ": " + message)); } private Task callWithExistingReactInstance(