Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename LayoutableShadowNode::measure to LayoutableShadowNode::measureContent

Browse Source 
Summary:
Changelog: [internal]

Rename `LayoutableShadowNode::measure` to `LayoutableShadowNode::measureContent` and add LayoutContext as parameter.

Pass `LayoutConstraints` by reference rather than value.

Reviewed By: shergin

Differential Revision: D22043727

fbshipit-source-id: b668240c45b658db5b114630b73d7407d35482aa
This commit is contained in:
Samuel Susla
2020-06-17 10:20:48 -07:00
committed by Facebook GitHub Bot
parent 6afc984e81
commit ec9da43de5
13 changed files with 39 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactCommon/fabric/components/textinput/androidtextinput/AndroidTextInputShadowNode.cpp
+3 -2
View File
@@ -165,8 +165,9 @@ void AndroidTextInputShadowNode::updateStateIfNeeded() {
#pragma mark - LayoutableShadowNode
Size AndroidTextInputShadowNode::measure(
LayoutConstraints layoutConstraints) const {
Size AndroidTextInputShadowNode::measureContent(
LayoutContext const &layoutContext,
LayoutConstraints const &layoutConstraints) const {
// Layout is called right after measure.
// Measure is marked as `const`, and `layout` is not; so State can be updated
// during layout, but not during `measure`. If State is out-of-date in layout,