From ebdf36c198193f5182d5e1b9792990455394bbf6 Mon Sep 17 00:00:00 2001 From: Tim Yung Date: Thu, 8 Apr 2021 17:34:51 -0700 Subject: [PATCH] RN: Upgrade `AccessibilityInfo.removeEventListener` Call Sites Summary: Upgrades all users of `AccessibilityInfo.removeEventListener` to instead use the return value of `AccessibilityInfo.addEventListener`. This will avoid soft errors from being fired for Facebook products. Changelog: [Internal] Reviewed By: kacieb Differential Revision: D27595097 fbshipit-source-id: 7133db83c6313ae04e43fc0cc8667f562ba1af2b --- .../js/examples/Accessibility/AccessibilityExample.js | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js b/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js index b975bf5bc1c..3f6611d05fc 100644 --- a/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js +++ b/packages/rn-tester/js/examples/Accessibility/AccessibilityExample.js @@ -837,7 +837,7 @@ class EnabledExample extends React.Component<{}> { }; componentDidMount() { - AccessibilityInfo.addEventListener( + this._subscription = AccessibilityInfo.addEventListener( this.props.eventListener, this._handleToggled, ); @@ -853,10 +853,7 @@ class EnabledExample extends React.Component<{}> { } componentWillUnmount() { - AccessibilityInfo.removeEventListener( - this.props.eventListener, - this._handleToggled, - ); + this._subscription?.remove(); } _handleToggled = isEnabled => {