From eaf8f8a161f38dab0885b40d0248f95f186b9d2c Mon Sep 17 00:00:00 2001
From: Phillip Pan <phillippan@meta.com>
Date: Tue, 28 Mar 2023 15:55:14 -0700
Subject: [PATCH] decouple BaseJavaModuleTest from PowerMock (#36670)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/36670

Changelog: [Internal]

so powermock doesn't have compatibility with JDK 18 (not sure what RN is on), but regardless my understanding is that we should be moving away from powermock since it's not maintained anymore.

this test was disabled because of that so this should allow it to run again.

Reviewed By: javache, cortinico

Differential Revision: D44445586

fbshipit-source-id: f9cabe80332a9ef11df690ac2af20bd60bb61641
---
 .../react/bridge/BaseJavaModuleTest.java      | 35 +++++++++++--------
 1 file changed, 21 insertions(+), 14 deletions(-)

diff --git a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/BaseJavaModuleTest.java b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/BaseJavaModuleTest.java
index 6e88e4d9f67..1b1ec28716c 100644
--- a/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/BaseJavaModuleTest.java
+++ b/packages/react-native/ReactAndroid/src/test/java/com/facebook/react/bridge/BaseJavaModuleTest.java
@@ -9,28 +9,36 @@ package com.facebook.react.bridge;
 
 import static org.mockito.Mockito.when;
 
+import android.content.Context;
 import com.facebook.soloader.SoLoader;
 import java.util.List;
 import org.junit.Before;
-import org.junit.Ignore;
-import org.junit.Rule;
 import org.junit.Test;
 import org.junit.runner.RunWith;
-import org.powermock.api.mockito.PowerMockito;
-import org.powermock.core.classloader.annotations.PowerMockIgnore;
-import org.powermock.core.classloader.annotations.PrepareForTest;
-import org.powermock.modules.junit4.rule.PowerMockRule;
+import org.mockito.Mockito;
 import org.robolectric.RobolectricTestRunner;
+import org.robolectric.annotation.Config;
+import org.robolectric.annotation.Implementation;
+import org.robolectric.annotation.Implements;
+
+@Implements(SoLoader.class)
+class ShadowSoLoader {
+  @Implementation
+  public static void init(Context context, int flags) {}
+
+  @Implementation
+  public static boolean loadLibrary(String shortName) {
+    return true;
+  }
+}
 
 /** Tests for {@link BaseJavaModule} and {@link JavaModuleWrapper} */
-@PrepareForTest({ReadableNativeArray.class, SoLoader.class})
-@PowerMockIgnore({"org.mockito.*", "org.robolectric.*", "androidx.*", "android.*"})
+@Config(
+    shadows = {
+      ShadowSoLoader.class,
+    })
 @RunWith(RobolectricTestRunner.class)
-@Ignore("Ignored due to unsupported mocking mechanism with JDK 18")
 public class BaseJavaModuleTest {
-
-  @Rule public PowerMockRule rule = new PowerMockRule();
-
   private List<JavaModuleWrapper.MethodDescriptor> mMethods;
   private JavaModuleWrapper mWrapper;
   private ReadableNativeArray mArguments;
@@ -40,8 +48,7 @@ public class BaseJavaModuleTest {
     ModuleHolder moduleHolder = new ModuleHolder(new MethodsModule());
     mWrapper = new JavaModuleWrapper(null, moduleHolder);
     mMethods = mWrapper.getMethodDescriptors();
-    PowerMockito.mockStatic(SoLoader.class);
-    mArguments = PowerMockito.mock(ReadableNativeArray.class);
+    mArguments = Mockito.mock(ReadableNativeArray.class);
   }
 
   private int findMethod(String mname, List<JavaModuleWrapper.MethodDescriptor> methods) {