From ea712f825a27c4afa5cc2891aca5be599f70bcf8 Mon Sep 17 00:00:00 2001
From: Andrei Shikov <ashikov@fb.com>
Date: Sun, 16 Jan 2022 23:06:11 -0800
Subject: [PATCH] Use reference when copying strings into mapbuffer

Summary:
This method can produce unnecessary copy of the string, replacing it with reference to optimize.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D33607765

fbshipit-source-id: e04eddffec063c0c8e173bfdf690e7b8e1050525
---
 ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp | 2 +-
 ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp b/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp
index f9373362a35..eb1c155a1cd 100644
--- a/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp
+++ b/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.cpp
@@ -125,7 +125,7 @@ void MapBufferBuilder::ensureDynamicDataSpace(int32_t size) {
   }
 }
 
-void MapBufferBuilder::putString(Key key, std::string value) {
+void MapBufferBuilder::putString(Key key, std::string const &value) {
   int32_t strLength = static_cast<int32_t>(value.length());
   const char *cstring = getCstring(&value);
 
diff --git a/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h b/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h
index ef198cb2e14..f7190f7fd38 100644
--- a/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h
+++ b/ReactCommon/react/renderer/mapbuffer/MapBufferBuilder.h
@@ -82,7 +82,7 @@ class MapBufferBuilder {
 
   void putNull(Key key);
 
-  void putString(Key key, std::string value);
+  void putString(Key key, std::string const &value);
 
   void putMapBuffer(Key key, MapBuffer &map);