From e9f29a32913fc6e3caaaa7e4feaccb1f2e3914e6 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Tue, 28 Apr 2020 21:44:23 -0700 Subject: [PATCH] Reject promise when if an error occurs while processing prefetching result Summary: This diff rejects the promise when if an error occurs while processing prefetching result, it applies the same concept as other methods in this class (e.g. see getSizeWithHeaders) changelog: [internal][Android] Internal change in RN Image prefetching Reviewed By: JoshuaGross Differential Revision: D21295612 fbshipit-source-id: c3675e5f2d9c8e38094a538b388ff63a6ea18360 --- .../com/facebook/react/modules/image/ImageLoaderModule.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.java b/ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.java index aca084ed9f3..aec08eea1f7 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.java +++ b/ReactAndroid/src/main/java/com/facebook/react/modules/image/ImageLoaderModule.java @@ -9,6 +9,7 @@ package com.facebook.react.modules.image; import android.net.Uri; import android.util.SparseArray; +import androidx.annotation.NonNull; import androidx.annotation.Nullable; import com.facebook.common.executors.CallerThreadExecutor; import com.facebook.common.references.CloseableReference; @@ -58,6 +59,7 @@ public class ImageLoaderModule extends NativeImageLoaderAndroidSpec } @Override + @NonNull public String getName() { return NAME; } @@ -212,6 +214,8 @@ public class ImageLoaderModule extends NativeImageLoaderAndroidSpec try { removeRequest(requestId); promise.resolve(true); + } catch (Exception e) { + promise.reject(ERROR_PREFETCH_FAILURE, e); } finally { dataSource.close(); }