Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Renaming Timing to TimingModule

Browse Source 
Summary: Most of our other native modules end in 'module', so let's update Timing to match.

Reviewed By: RSNara

Differential Revision: D17260848

fbshipit-source-id: 808b4d370a7036a247724fda5ab7210ac985476b
This commit is contained in:
Emily Janzer
2019-09-19 11:47:17 -07:00
committed by Facebook Github Bot
parent 757966837a
commit e9b50fa4ee
4 changed files with 51 additions and 50 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/test/java/com/facebook/react/modules/timing/TimingModuleTest.java
+35 -35
View File
@@ -17,7 +17,7 @@ import com.facebook.react.devsupport.interfaces.DevSupportManager;
import com.facebook.react.modules.core.ChoreographerCompat;
import com.facebook.react.modules.core.JSTimers;
import com.facebook.react.modules.core.ReactChoreographer;
import com.facebook.react.modules.core.Timing;
import com.facebook.react.modules.core.TimingModule;
import org.junit.Before;
import org.junit.Rule;
import org.junit.Test;
@@ -30,7 +30,7 @@ import org.powermock.core.classloader.annotations.PrepareForTest;
import org.powermock.modules.junit4.rule.PowerMockRule;
import org.robolectric.RobolectricTestRunner;
/** Tests for {@link Timing}. */
/** Tests for {@link TimingModule}. */
// DISABLED, BROKEN https://circleci.com/gh/facebook/react-native/12068
// t=13905097
@PrepareForTest({Arguments.class, SystemClock.class, ReactChoreographer.class})
@@ -40,7 +40,7 @@ public class TimingModuleTest {
private static final long FRAME_TIME_NS = 17 * 1000 * 1000; // 17 ms
private Timing mTiming;
private TimingModule mTimingModule;
private ReactChoreographer mReactChoreographerMock;
private PostFrameCallbackHandler mPostFrameCallbackHandler;
private PostFrameIdleCallbackHandler mIdlePostFrameCallbackHandler;
@@ -90,7 +90,7 @@ public class TimingModuleTest {
eq(ReactChoreographer.CallbackType.IDLE_EVENT),
any(ChoreographerCompat.FrameCallback.class));
mTiming = new Timing(reactContext, mock(DevSupportManager.class));
mTimingModule = new TimingModule(reactContext, mock(DevSupportManager.class));
mJSTimersMock = mock(JSTimers.class);
when(reactContext.getJSModule(JSTimers.class)).thenReturn(mJSTimersMock);
@@ -105,7 +105,7 @@ public class TimingModuleTest {
.when(reactContext)
.runOnJSQueueThread(any(Runnable.class));
mTiming.initialize();
mTimingModule.initialize();
}
private void stepChoreographerFrame() {
@@ -127,8 +127,8 @@ public class TimingModuleTest {
@Test
public void testSimpleTimer() {
mTiming.onHostResume();
mTiming.createTimer(1, 1, 0, false);
mTimingModule.onHostResume();
mTimingModule.createTimer(1, 1, 0, false);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(1.0));
reset(mJSTimersMock);
@@ -138,8 +138,8 @@ public class TimingModuleTest {
@Test
public void testSimpleRecurringTimer() {
mTiming.createTimer(100, 1, 0, true);
mTiming.onHostResume();
mTimingModule.createTimer(100, 1, 0, true);
mTimingModule.onHostResume();
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(100.0));
@@ -150,103 +150,103 @@ public class TimingModuleTest {
@Test
public void testCancelRecurringTimer() {
mTiming.onHostResume();
mTiming.createTimer(105, 1, 0, true);
mTimingModule.onHostResume();
mTimingModule.createTimer(105, 1, 0, true);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(105.0));
reset(mJSTimersMock);
mTiming.deleteTimer(105);
mTimingModule.deleteTimer(105);
stepChoreographerFrame();
verifyNoMoreInteractions(mJSTimersMock);
}
@Test
public void testPausingAndResuming() {
mTiming.onHostResume();
mTiming.createTimer(41, 1, 0, true);
mTimingModule.onHostResume();
mTimingModule.createTimer(41, 1, 0, true);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHostPause();
mTimingModule.onHostPause();
stepChoreographerFrame();
verifyNoMoreInteractions(mJSTimersMock);
reset(mJSTimersMock);
mTiming.onHostResume();
mTimingModule.onHostResume();
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
}
@Test
public void testHeadlessJsTaskInBackground() {
mTiming.onHostPause();
mTiming.onHeadlessJsTaskStart(42);
mTiming.createTimer(41, 1, 0, true);
mTimingModule.onHostPause();
mTimingModule.onHeadlessJsTaskStart(42);
mTimingModule.createTimer(41, 1, 0, true);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHeadlessJsTaskFinish(42);
mTimingModule.onHeadlessJsTaskFinish(42);
stepChoreographerFrame();
verifyNoMoreInteractions(mJSTimersMock);
}
@Test
public void testHeadlessJsTaskInForeground() {
mTiming.onHostResume();
mTiming.onHeadlessJsTaskStart(42);
mTiming.createTimer(41, 1, 0, true);
mTimingModule.onHostResume();
mTimingModule.onHeadlessJsTaskStart(42);
mTimingModule.createTimer(41, 1, 0, true);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHeadlessJsTaskFinish(42);
mTimingModule.onHeadlessJsTaskFinish(42);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHostPause();
mTimingModule.onHostPause();
verifyNoMoreInteractions(mJSTimersMock);
}
@Test
public void testHeadlessJsTaskIntertwine() {
mTiming.onHostResume();
mTiming.onHeadlessJsTaskStart(42);
mTiming.createTimer(41, 1, 0, true);
mTiming.onHostPause();
mTimingModule.onHostResume();
mTimingModule.onHeadlessJsTaskStart(42);
mTimingModule.createTimer(41, 1, 0, true);
mTimingModule.onHostPause();
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHostResume();
mTiming.onHeadlessJsTaskFinish(42);
mTimingModule.onHostResume();
mTimingModule.onHeadlessJsTaskFinish(42);
stepChoreographerFrame();
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(41.0));
reset(mJSTimersMock);
mTiming.onHostPause();
mTimingModule.onHostPause();
stepChoreographerFrame();
verifyNoMoreInteractions(mJSTimersMock);
}
@Test
public void testSetTimeoutZero() {
mTiming.createTimer(100, 0, 0, false);
mTimingModule.createTimer(100, 0, 0, false);
verify(mJSTimersMock).callTimers(JavaOnlyArray.of(100.0));
}
@Test
public void testIdleCallback() {
mTiming.onHostResume();
mTiming.setSendIdleEvents(true);
mTimingModule.onHostResume();
mTimingModule.setSendIdleEvents(true);
stepChoreographerFrame();
verify(mJSTimersMock).callIdleCallbacks(SystemClock.currentTimeMillis());