Renaming Timing to TimingModule

Summary: Most of our other native modules end in 'module', so let's update Timing to match.

Reviewed By: RSNara

Differential Revision: D17260848

fbshipit-source-id: 808b4d370a7036a247724fda5ab7210ac985476b
This commit is contained in:
Emily Janzer
2019-09-19 11:47:17 -07:00
committed by Facebook Github Bot
parent 757966837a
commit e9b50fa4ee
4 changed files with 51 additions and 50 deletions
@@ -6,7 +6,6 @@
*/
package com.facebook.react;
import static com.facebook.react.bridge.ReactMarkerConstants.*;
import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_UI_MANAGER_MODULE_END;
import static com.facebook.react.bridge.ReactMarkerConstants.CREATE_UI_MANAGER_MODULE_START;
import static com.facebook.react.bridge.ReactMarkerConstants.PROCESS_CORE_REACT_PACKAGE_END;
@@ -24,7 +23,7 @@ import com.facebook.react.modules.core.DefaultHardwareBackBtnHandler;
import com.facebook.react.modules.core.DeviceEventManagerModule;
import com.facebook.react.modules.core.ExceptionsManagerModule;
import com.facebook.react.modules.core.HeadlessJsTaskSupportModule;
import com.facebook.react.modules.core.Timing;
import com.facebook.react.modules.core.TimingModule;
import com.facebook.react.modules.debug.DevSettingsModule;
import com.facebook.react.modules.debug.SourceCodeModule;
import com.facebook.react.modules.deviceinfo.DeviceInfoModule;
@@ -51,7 +50,7 @@ import java.util.Map;
ExceptionsManagerModule.class,
HeadlessJsTaskSupportModule.class,
SourceCodeModule.class,
Timing.class,
TimingModule.class,
UIManagerModule.class,
})
/* package */ class CoreModulesPackage extends TurboReactPackage implements ReactPackageLogger {
@@ -96,7 +95,7 @@ import java.util.Map;
ExceptionsManagerModule.class,
HeadlessJsTaskSupportModule.class,
SourceCodeModule.class,
Timing.class,
TimingModule.class,
UIManagerModule.class
};
@@ -146,8 +145,8 @@ import java.util.Map;
return new HeadlessJsTaskSupportModule(reactContext);
case SourceCodeModule.NAME:
return new SourceCodeModule(reactContext);
case Timing.NAME:
return new Timing(reactContext, mReactInstanceManager.getDevSupportManager());
case TimingModule.NAME:
return new TimingModule(reactContext, mReactInstanceManager.getDevSupportManager());
case UIManagerModule.NAME:
return createUIManager(reactContext);
case DeviceInfoModule.NAME:
@@ -25,13 +25,13 @@ import java.util.PriorityQueue;
import java.util.concurrent.atomic.AtomicBoolean;
/** Native module for JS timer execution. Timers fire on frame boundaries. */
@ReactModule(name = Timing.NAME)
public final class Timing extends ReactContextBaseJavaModule
@ReactModule(name = TimingModule.NAME)
public final class TimingModule extends ReactContextBaseJavaModule
implements LifecycleEventListener, HeadlessJsTaskEventListener {
public static final String NAME = "Timing";
// These timing contants should be kept in sync with the ones in `JSTimers.js`.
// These timing constants should be kept in sync with the ones in `JSTimers.js`.
// The minimum time in milliseconds left in the frame to call idle callbacks.
private static final float IDLE_CALLBACK_FRAME_DEADLINE_MS = 1.f;
// The total duration of a frame in milliseconds, this assumes that devices run at 60 fps.
@@ -170,7 +170,7 @@ public final class Timing extends ReactContextBaseJavaModule
private boolean mFrameIdleCallbackPosted = false;
private boolean mSendIdleEvents = false;
public Timing(ReactApplicationContext reactContext, DevSupportManager devSupportManager) {
public TimingModule(ReactApplicationContext reactContext, DevSupportManager devSupportManager) {
super(reactContext);
mDevSupportManager = devSupportManager;
// We store timers sorted by finish time.