From e90735b4efea669989f38b976e66e368e1783a8d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dawid=20Ma=C5=82ecki?= Date: Tue, 31 Mar 2026 08:32:57 -0700 Subject: [PATCH] Exclude Apple Switch component from the ReactAndroid C++ API snapshot (#56249) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/56249 Prevents iOS Switch component leaking into the ReactAndroid snapshot by adding `*/components/switch/iosswitch/*` path to the `exclude_patterns` in the parser config. Changelog: [Internal] Reviewed By: cipolleschi Differential Revision: D98473064 fbshipit-source-id: de25c4cbe839f8a065b8465e48a2b8c2a5ba81d7 --- .../cxx-api/api-snapshots/ReactAndroidDebugCxx.api | 13 ------------- .../api-snapshots/ReactAndroidReleaseCxx.api | 13 ------------- scripts/cxx-api/config.yml | 1 + 3 files changed, 1 insertion(+), 26 deletions(-) diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index ee3b1d675c8..668a8c43765 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -454,7 +454,6 @@ const char facebook::react::AndroidHorizontalScrollContentViewShadowNodeComponen const char facebook::react::AndroidProgressBarComponentName[]; const char facebook::react::AndroidSwitchComponentName[]; const char facebook::react::AndroidTextInputComponentName[]; -const char facebook::react::AppleSwitchComponentName[]; const char facebook::react::ImageComponentName[]; const char facebook::react::ImageFetcherKey[]; const char facebook::react::ImageManagerKey[]; @@ -4911,11 +4910,6 @@ class facebook::react::SurfaceTelemetry { public void incorporate(const facebook::react::TransactionTelemetry& telemetry, int numberOfMutations); } -class facebook::react::SwitchComponentDescriptor : public facebook::react::ConcreteComponentDescriptor { - public SwitchComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); - public virtual void adopt(facebook::react::ShadowNode& shadowNode) const override; -} - class facebook::react::SwitchEventEmitter : public facebook::react::BaseViewEventEmitter { public void onChange(facebook::react::SwitchEventEmitter::OnChange value) const; } @@ -4940,13 +4934,6 @@ class facebook::react::SwitchProps : public facebook::react::HostPlatformViewPro public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override; } -class facebook::react::SwitchShadowNode : public facebook::react::ConcreteViewShadowNode { - public SwitchShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); - public SwitchShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); - public static facebook::react::ShadowNodeTraits BaseTraits(); - public virtual facebook::react::Size measureContent(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const override; -} - class facebook::react::TaskPriorityComparer { public bool operator()(const std::shared_ptr& lhs, const std::shared_ptr& rhs); } diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index fa621d98bc7..bcb202834cb 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -454,7 +454,6 @@ const char facebook::react::AndroidHorizontalScrollContentViewShadowNodeComponen const char facebook::react::AndroidProgressBarComponentName[]; const char facebook::react::AndroidSwitchComponentName[]; const char facebook::react::AndroidTextInputComponentName[]; -const char facebook::react::AppleSwitchComponentName[]; const char facebook::react::ImageComponentName[]; const char facebook::react::ImageFetcherKey[]; const char facebook::react::ImageManagerKey[]; @@ -4902,11 +4901,6 @@ class facebook::react::SurfaceTelemetry { public void incorporate(const facebook::react::TransactionTelemetry& telemetry, int numberOfMutations); } -class facebook::react::SwitchComponentDescriptor : public facebook::react::ConcreteComponentDescriptor { - public SwitchComponentDescriptor(const facebook::react::ComponentDescriptorParameters& parameters); - public virtual void adopt(facebook::react::ShadowNode& shadowNode) const override; -} - class facebook::react::SwitchEventEmitter : public facebook::react::BaseViewEventEmitter { public void onChange(facebook::react::SwitchEventEmitter::OnChange value) const; } @@ -4931,13 +4925,6 @@ class facebook::react::SwitchProps : public facebook::react::HostPlatformViewPro public virtual folly::dynamic getDiffProps(const facebook::react::Props* prevProps) const override; } -class facebook::react::SwitchShadowNode : public facebook::react::ConcreteViewShadowNode { - public SwitchShadowNode(const facebook::react::ShadowNode& sourceShadowNode, const facebook::react::ShadowNodeFragment& fragment); - public SwitchShadowNode(const facebook::react::ShadowNodeFragment& fragment, const facebook::react::ShadowNodeFamily::Shared& family, facebook::react::ShadowNodeTraits traits); - public static facebook::react::ShadowNodeTraits BaseTraits(); - public virtual facebook::react::Size measureContent(const facebook::react::LayoutContext& layoutContext, const facebook::react::LayoutConstraints& layoutConstraints) const override; -} - class facebook::react::TaskPriorityComparer { public bool operator()(const std::shared_ptr& lhs, const std::shared_ptr& rhs); } diff --git a/scripts/cxx-api/config.yml b/scripts/cxx-api/config.yml index ba54235b965..35bc28210f8 100644 --- a/scripts/cxx-api/config.yml +++ b/scripts/cxx-api/config.yml @@ -43,6 +43,7 @@ platforms: - packages/react-native/ReactAndroid exclude_patterns: - "*/ReactAndroid/src/main/jni/react/featureflags/*" + - "*/components/switch/iosswitch/*" - "*/platform/cxx/*" - "*/platform/windows/*" - "*/platform/macos/*"