From e8663ffabafaf4b413b6306e2c22c51b5754f5bc Mon Sep 17 00:00:00 2001 From: Hector Ramos Date: Fri, 21 Sep 2018 10:24:43 -0700 Subject: [PATCH] Updated error message, and fail on analyze --- .circleci/config.yml | 2 ++ scripts/publish-npm.js | 7 ++++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/.circleci/config.yml b/.circleci/config.yml index bb4a9923353..98a03a57b16 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -676,6 +676,8 @@ workflows: tags: only: /v[0-9]+(\.[0-9]+)*(\-rc(\.[0-9]+)?)?/ requires: + - analyze + - test_detox_end_to_end - test_javascript - test_objc - test_android diff --git a/scripts/publish-npm.js b/scripts/publish-npm.js index 5fffbc471ae..6fcacd2f38e 100644 --- a/scripts/publish-npm.js +++ b/scripts/publish-npm.js @@ -55,9 +55,14 @@ require('shelljs/global'); const buildTag = process.env.CIRCLE_TAG; const otp = process.env.NPM_CONFIG_OTP; +if (!buildTag) { + echo('Error: We publish only from git tags'); + exit(1); +} + let match = buildTag.match(/^v(\d+\.\d+)\.\d+(?:-.+)?$/); if (!match) { - echo('Error: We publish only from stable branches'); + echo('Error: We publish only from release version git tags'); exit(1); } // 0.33