From e82bb7beb525d6de4e0210da352341ec91c94498 Mon Sep 17 00:00:00 2001 From: Luna Wei Date: Tue, 13 Jun 2023 07:32:13 -0700 Subject: [PATCH] rn-ci-e2e-test CircleCI using wrong parameters (#37852) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/37852 Changelog: [Internal] - rn-ci-e2e-test is running on CircleCI but has been passing in the wrong parameter with `--version` -- which didn't evaluate the script, it would early exit as `--version` is a reserved parameter in yargs. You can see if you do `node scripts/set-rn-version.js --help` When I fixed this [here](https://www.internalfb.com/diff/D46511840?dst_version_fbid=827076485041949&transaction_fbid=625055476222975), forgot to pass `build-type` parameter This will fix the broken testjs e2e builds here: https://app.circleci.com/pipelines/github/facebook/react-native/25703/workflows/11a41ba1-c731-44e4-b515-a8b209ae0848/jobs/732035 Reviewed By: rshest Differential Revision: D46672741 fbshipit-source-id: 4a189127e4d0545192a03c1e7abc995dff6f83ae --- scripts/run-ci-e2e-tests.js | 6 +++++- scripts/set-rn-version.js | 1 + 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/scripts/run-ci-e2e-tests.js b/scripts/run-ci-e2e-tests.js index 56550cc262b..fbab0b3bc71 100644 --- a/scripts/run-ci-e2e-tests.js +++ b/scripts/run-ci-e2e-tests.js @@ -64,7 +64,11 @@ try { } describe('Create react-native package'); - if (exec('node ./scripts/set-rn-version.js --to-version 1000.0.0').code) { + if ( + exec( + 'node ./scripts/set-rn-version.js --to-version 1000.0.0 --build-type dry-run', + ).code + ) { echo('Failed to set version and update package.json ready for release'); exitCode = 1; throw Error(exitCode); diff --git a/scripts/set-rn-version.js b/scripts/set-rn-version.js index ad8603471b4..4081ee42afb 100755 --- a/scripts/set-rn-version.js +++ b/scripts/set-rn-version.js @@ -49,6 +49,7 @@ if (require.main === module) { .option('b', { alias: 'build-type', type: 'string', + choices: ['dry-run', 'nightly', 'release'], required: true, }).argv;