Add IntBuffer and DoubleBuffer entry types to MapBuffer (#57359)

Summary:
Pull Request resolved: https://github.com/react/react-native/pull/57359

Adds two new MapBuffer entry types, `IntBuffer` and `DoubleBuffer`, for storing homogeneous arrays of ints and doubles compactly in the dynamic data section. Unlike `Map` / map lists, these carry no per-element key/type overhead: a batch of N values costs ~N*elementSize bytes plus a single 4-byte count prefix instead of N 12-byte buckets. The bucket value holds the offset of the array within the dynamic data section.

Covers the full surface: the C++ reader (`MapBuffer::getIntBuffer` / `getDoubleBuffer`), the C++ builder (`MapBufferBuilder::putIntBuffer` / `putDoubleBuffer`), and the Kotlin reader API (`MapBuffer.getIntBuffer` / `getDoubleBuffer`, `Entry.intBufferValue` / `doubleBufferValue`). The `DataType` enum gains `IntBuffer = 6` and `DoubleBuffer = 7`, kept in sync across C++ and Kotlin.

Changelog:
[General][Added] - Add `IntBuffer` and `DoubleBuffer` entry types to MapBuffer for compact homogeneous int/double arrays

landed-with-radar-review

Reviewed By: zeyap

Differential Revision: D109848476

fbshipit-source-id: f9e86b7c094dea796d9a8b725e53eb948c1390ca
This commit is contained in:
Pieter De Baets authored and meta-codesync[bot] committed 2026-07-03 01:41:41 -07:00
1 parent dfab628f8d
commit e7cadaf9f3
19 files changed
+382 -2

No files matched your search

@@ -3249,7 +3249,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -3257,7 +3259,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -3282,7 +3286,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);
@@ -3158,7 +3158,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -3166,7 +3168,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -3191,7 +3195,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);
@@ -3246,7 +3246,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -3254,7 +3256,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -3279,7 +3283,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);
@@ -5484,7 +5484,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -5492,7 +5494,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -5517,7 +5521,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);
@@ -5408,7 +5408,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -5416,7 +5418,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -5441,7 +5445,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);
@@ -5481,7 +5481,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -5489,7 +5491,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -5514,7 +5518,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);
@@ -2170,7 +2170,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -2178,7 +2180,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -2203,7 +2207,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);
@@ -2106,7 +2106,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -2114,7 +2116,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -2139,7 +2143,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);
@@ -2167,7 +2167,9 @@ class facebook::react::MapBuffer {
public size_t size() const;
public static constexpr uint16_t HEADER_ALIGNMENT;
public std::string getString(facebook::react::MapBuffer::Key key) const;
public std::vector<double> getDoubleBuffer(facebook::react::MapBuffer::Key key) const;
public std::vector<facebook::react::MapBuffer> getMapBufferList(facebook::react::MapBuffer::Key key) const;
public std::vector<int32_t> getIntBuffer(facebook::react::MapBuffer::Key key) const;
public uint16_t count() const;
public using Key = uint16_t;
}
@@ -2175,7 +2177,9 @@ class facebook::react::MapBuffer {
enum facebook::react::MapBuffer::DataType : uint16_t {
Boolean,
Double,
DoubleBuffer,
Int,
IntBuffer,
Long,
Map,
String,
@@ -2200,7 +2204,9 @@ class facebook::react::MapBufferBuilder {
public static facebook::react::MapBuffer EMPTY();
public void putBool(facebook::react::MapBuffer::Key key, bool value);
public void putDouble(facebook::react::MapBuffer::Key key, double value);
public void putDoubleBuffer(facebook::react::MapBuffer::Key key, const std::vector<double>& value);
public void putInt(facebook::react::MapBuffer::Key key, int32_t value);
public void putIntBuffer(facebook::react::MapBuffer::Key key, const std::vector<int32_t>& value);
public void putLong(facebook::react::MapBuffer::Key key, int64_t value);
public void putMapBuffer(facebook::react::MapBuffer::Key key, const facebook::react::MapBuffer& map);
public void putMapBufferList(facebook::react::MapBuffer::Key key, const std::vector<facebook::react::MapBuffer>& mapBufferList);