Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rename addRootView -> startSurface in Fabric, and deprecate existing addRootView sites

Browse Source 
Summary:
Deprecate addRootView, use startSurface consistently in Fabric.

Changelog: [Internal]

Reviewed By: mdvacca

Differential Revision: D26021147

fbshipit-source-id: e23b9294695609f766e382917ae1874fc8a1b27d
This commit is contained in:
Joshua Gross
2021-01-22 19:29:00 -08:00
committed by Facebook GitHub Bot
parent 505f9fc749
commit e7783ff9ad
4 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/uimanager/UIManagerModule.java
+4
View File
@@ -436,6 +436,10 @@ public class UIManagerModule extends ReactContextBaseJavaModule
* Registers a new root view. JS can use the returned tag with manageChildren to add/remove
* children to this view.
*
* <p>Calling addRootView through UIManagerModule calls addRootView in the non-Fabric renderer,
* always. This is deprecated in favor of calling startSurface in Fabric, which must be done
* directly through the FabricUIManager.
*
* <p>Note that this must be called after getWidth()/getHeight() actually return something. See
* CatalystApplicationFragment as an example.
*