Calling Paper TextInput setTextAndSelection view command now dirties layout

Summary:
Changelog: [Internal]

Previously `setTextAndSelection` was not dirtying layout. This would cause an issue where `setTextAndSelection` causes layout change. For example calling setTextAndSelection with empty string on a multiline auto expanding text input.

I changed one example in TextInputSharedExamples.js, "Live Re-Write (no spaces allowed) and clear" example is now multiline. This allows to test whether `setTextAndSelection` dirties layout. Enter multiline string to to the example text input and press clear. Observe that the text input shrinks to single line height.

Reviewed By: shergin

Differential Revision: D21182990

fbshipit-source-id: de8501ea0b97012cf4cdf8d5f658649139f92da6
This commit is contained in:
Samuel Susla
2020-04-27 03:23:34 -07:00
committed by Facebook GitHub Bot
parent e3e900805b
commit e68f9bf768
4 changed files with 22 additions and 18 deletions
@@ -161,9 +161,9 @@ class RewriteInvalidCharactersAndClearExample extends React.Component<
ref={ref => {
this.inputRef = ref;
}}
multiline={false}
multiline={true}
onChangeText={text => {
this.setState({text: text.replace(/\s/g, '')});
this.setState({text: text.replace(/ /g, '')});
}}
style={styles.default}
value={this.state.text}