Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Potential fix for, and more diagnostics for, NativeAnimatedModule crash

Browse Source 
Summary:
Searching for details and maybe a fix for T68843308 crashing in disconnectFromView, "Attempting to disconnect view that has not been connected with the given animated node".

May be related to recent refactoring but it's not clear. Change logic slightly and add more diagnostic information.

Changelog: [Internal]

Reviewed By: shergin

Differential Revision: D22153179

fbshipit-source-id: b95dbaf01ae8bca154c61442898b0f9d3aebb4de
This commit is contained in:
Joshua Gross
2020-06-20 17:47:29 -07:00
committed by Facebook GitHub Bot
parent 9760a326c9
commit e661a551cb
1 changed files with 6 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/animated/PropsAnimatedNode.java
+6 -3
View File
@@ -45,17 +45,20 @@ import java.util.Map;
public void connectToView(int viewTag, UIManager uiManager) {
if (mConnectedViewTag != -1) {
throw new JSApplicationIllegalArgumentException(
"Animated node " + mTag + " is " + "already attached to a view");
"Animated node " + mTag + " is " + "already attached to a view: " + mConnectedViewTag);
}
mConnectedViewTag = viewTag;
mUIManager = uiManager;
}
public void disconnectFromView(int viewTag) {
if (mConnectedViewTag != viewTag) {
if (mConnectedViewTag != viewTag && mConnectedViewTag != -1) {
throw new JSApplicationIllegalArgumentException(
"Attempting to disconnect view that has "
+ "not been connected with the given animated node");
+ "not been connected with the given animated node: "
+ viewTag
+ " but is connected to view "
+ mConnectedViewTag);
}
mConnectedViewTag = -1;