From e54f3ee14fdcc8eafc65795ca9c86002d7bbc5a5 Mon Sep 17 00:00:00 2001 From: CodemodService Bot Date: Tue, 23 Sep 2025 05:45:53 -0700 Subject: [PATCH] Fix CQS signal readability-avoid-const-params-in-decls in xplat/js/react-native-github/packages [B] Reviewed By: javache Differential Revision: D83033554 --- .../react-native/ReactCommon/cxxreact/JSExecutor.h | 2 +- .../ReactCommon/cxxreact/JSIndexedRAMBundle.h | 8 ++++---- .../ReactCommon/cxxreact/ReactMarker.h | 14 ++++++-------- .../ReactCommon/jsiexecutor/jsireact/JSIExecutor.h | 2 +- 4 files changed, 12 insertions(+), 14 deletions(-) diff --git a/packages/react-native/ReactCommon/cxxreact/JSExecutor.h b/packages/react-native/ReactCommon/cxxreact/JSExecutor.h index 246a8c464c6..f65ab5d7af9 100644 --- a/packages/react-native/ReactCommon/cxxreact/JSExecutor.h +++ b/packages/react-native/ReactCommon/cxxreact/JSExecutor.h @@ -106,7 +106,7 @@ class RN_EXPORT [[deprecated( * necessary native modules methods. */ virtual void invokeCallback( - const double callbackId, + double callbackId, const folly::dynamic& arguments) = 0; virtual void setGlobalVariable( diff --git a/packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h b/packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h index 1e6f8f1c5d4..dc7b9b3d436 100644 --- a/packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h +++ b/packages/react-native/ReactCommon/cxxreact/JSIndexedRAMBundle.h @@ -61,12 +61,12 @@ class RN_EXPORT [[deprecated( }; void init(); - std::string getModuleCode(const uint32_t id) const; - void readBundle(char* buffer, const std::streamsize bytes) const; + std::string getModuleCode(uint32_t id) const; + void readBundle(char* buffer, std::streamsize bytes) const; void readBundle( char* buffer, - const std::streamsize bytes, - const std::istream::pos_type position) const; + std::streamsize bytes, + std::istream::pos_type position) const; mutable std::unique_ptr m_bundle; ModuleTable m_table; diff --git a/packages/react-native/ReactCommon/cxxreact/ReactMarker.h b/packages/react-native/ReactCommon/cxxreact/ReactMarker.h index 8b4a95234dc..9c2f2e7628c 100644 --- a/packages/react-native/ReactCommon/cxxreact/ReactMarker.h +++ b/packages/react-native/ReactCommon/cxxreact/ReactMarker.h @@ -57,13 +57,13 @@ extern RN_EXPORT std::shared_mutex logTaggedMarkerImplMutex; extern RN_EXPORT LogTaggedMarker logTaggedMarkerImpl; extern RN_EXPORT LogTaggedMarker logTaggedMarkerBridgelessImpl; -extern RN_EXPORT void logMarker(const ReactMarkerId markerId); // Bridge only +extern RN_EXPORT void logMarker(ReactMarkerId markerId); // Bridge only extern RN_EXPORT void logTaggedMarker( - const ReactMarkerId markerId, + ReactMarkerId markerId, const char* tag); // Bridge only -extern RN_EXPORT void logMarkerBridgeless(const ReactMarkerId markerId); +extern RN_EXPORT void logMarkerBridgeless(ReactMarkerId markerId); extern RN_EXPORT void logTaggedMarkerBridgeless( - const ReactMarkerId markerId, + ReactMarkerId markerId, const char* tag); struct ReactMarkerEvent { @@ -76,7 +76,7 @@ class RN_EXPORT StartupLogger { public: static StartupLogger& getInstance(); - void logStartupEvent(const ReactMarkerId markerId, double markerTime); + void logStartupEvent(ReactMarkerId markerId, double markerTime); void reset(); double getAppStartupStartTime(); double getInitReactRuntimeStartTime(); @@ -101,8 +101,6 @@ class RN_EXPORT StartupLogger { // When the marker got logged from the platform, it will notify here. This is // used to collect react markers that are logged in the platform instead of in // C++. -extern RN_EXPORT void logMarkerDone( - const ReactMarkerId markerId, - double markerTime); +extern RN_EXPORT void logMarkerDone(ReactMarkerId markerId, double markerTime); } // namespace facebook::react::ReactMarker diff --git a/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h b/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h index 89347dd93b7..08f61341bcb 100644 --- a/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h +++ b/packages/react-native/ReactCommon/jsiexecutor/jsireact/JSIExecutor.h @@ -91,7 +91,7 @@ class [[deprecated( const std::string& moduleId, const std::string& methodId, const folly::dynamic& arguments) override; - void invokeCallback(const double callbackId, const folly::dynamic& arguments) + void invokeCallback(double callbackId, const folly::dynamic& arguments) override; void setGlobalVariable( std::string propName,