From e4d8c967862f446a135de2d31f3eaacfc4a51f1c Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Thu, 21 Nov 2024 16:00:44 -0800 Subject: [PATCH] Correct message annotation on early js errors (#47889) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/47889 ## Context When is the runtime ready? - After the main bundle finishes executing **without** raising a fatal javascript error ## Changes Let's decorate all errors reported while the runtime is not ready as "[runtime not ready]". Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D66316907 fbshipit-source-id: e48542af4f84d4cc3a6ce8f667dbaa10c30c19a8 --- .../react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp index fda5c18920e..d423ade85d5 100644 --- a/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp +++ b/packages/react-native/ReactCommon/jserrorhandler/JsErrorHandler.cpp @@ -327,7 +327,8 @@ void JsErrorHandler::handleErrorWithCppPipeline( auto id = nextExceptionId(); ParsedError parsedError = { - .message = _isRuntimeReady ? message : ("EarlyJsError: " + message), + .message = + _isRuntimeReady ? message : ("[runtime not ready]: " + message), .originalMessage = originalMessage, .name = name, .componentStack = componentStack,