Fix precision of TextInlineViews in Android

Summary:
TextInlineViews in Android was incorrectly converting values to from float to int, this produced to loose precision and to render incomplete texts in some components.
This diff changed the types from int to float, avoiding loose precision.

The impact of this bug is not that high because in the conversion to int we were using Math.ceil(), which was already rounding the result to the next pixel.

changeLog: [Android][Fixed] Fix precision of TextInlineViews in Fabric Android

Reviewed By: JoshuaGross, shergin

Differential Revision: D21541159

fbshipit-source-id: 4741ab96964c35af1c1b7d3e821e505ecef2efce

ReactAndroid/src/main/java/com/facebook/react/fabric/FabricUIManager.java

@@ -464,7 +464,7 @@ public class FabricUIManager implements UIManager, LifecycleEventListener {
       float maxWidth,
       float minHeight,
       float maxHeight,
-      @Nullable int[] attachmentsPositions) {
+      @Nullable float[] attachmentsPositions) {
     ReactContext context =
         rootTag < 0 ? mReactApplicationContext : mReactContextForRootTag.get(rootTag);
     return mMountingManager.measure(

ReactAndroid/src/main/java/com/facebook/react/fabric/mounting/MountingManager.java

@@ -519,7 +519,7 @@ public class MountingManager {
       @NonNull YogaMeasureMode widthMode,
       float height,
       @NonNull YogaMeasureMode heightMode,
-      @Nullable int[] attachmentsPositions) {
+      @Nullable float[] attachmentsPositions) {
 
     return mViewManagerRegistry
         .get(componentName)

ReactAndroid/src/main/java/com/facebook/react/uimanager/ViewManager.java

@@ -318,7 +318,7 @@ public abstract class ViewManager<T extends View, C extends ReactShadowNode>
       YogaMeasureMode widthMode,
       float height,
       YogaMeasureMode heightMode,
-      @Nullable int[] attachmentsPositions) {
+      @Nullable float[] attachmentsPositions) {
     return 0;
   }
 

ReactAndroid/src/main/java/com/facebook/react/views/slider/ReactSliderManager.java

@@ -259,7 +259,7 @@ public class ReactSliderManager extends SimpleViewManager<ReactSlider>
       YogaMeasureMode widthMode,
       float height,
       YogaMeasureMode heightMode,
-      @Nullable int[] attachmentsPositions) {
+      @Nullable float[] attachmentsPositions) {
     SeekBar reactSlider = new ReactSlider(context, null, STYLE);
     final int spec =
         View.MeasureSpec.makeMeasureSpec(

ReactAndroid/src/main/java/com/facebook/react/views/switchview/ReactSwitchManager.java

@@ -210,7 +210,7 @@ public class ReactSwitchManager extends SimpleViewManager<ReactSwitch>
       YogaMeasureMode widthMode,
       float height,
       YogaMeasureMode heightMode,
-      @Nullable int[] attachmentsPositions) {
+      @Nullable float[] attachmentsPositions) {
     ReactSwitch view = new ReactSwitch(context);
     view.setShowText(false);
     int measureSpec = View.MeasureSpec.makeMeasureSpec(0, View.MeasureSpec.UNSPECIFIED);

ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextViewManager.java

@@ -120,7 +120,7 @@ public class ReactTextViewManager
       YogaMeasureMode widthMode,
       float height,
       YogaMeasureMode heightMode,
-      @Nullable int[] attachmentsPositions) {
+      @Nullable float[] attachmentsPositions) {
 
     return TextLayoutManager.measureText(
         context,

ReactAndroid/src/main/java/com/facebook/react/views/text/TextLayoutManager.java

@@ -216,7 +216,7 @@ public class TextLayoutManager {
       float height,
       YogaMeasureMode heightYogaMeasureMode,
       ReactTextViewManagerCallback reactTextViewManagerCallback,
-      @Nullable int[] attachmentsPositions) {
+      @Nullable float[] attachmentsPositions) {
 
     // TODO(5578671): Handle text direction (see View#getTextDirectionHeuristic)
     TextPaint textPaint = sTextPaintInstance;
@@ -234,6 +234,7 @@ public class TextLayoutManager {
     if (text == null) {
       throw new IllegalStateException("Spannable element has not been prepared in onBeforeLayout");
     }
+
     BoringLayout.Metrics boring = BoringLayout.isBoring(text, textPaint);
     float desiredWidth = boring == null ? Layout.getDesiredWidth(text, textPaint) : Float.NaN;
 
@@ -412,9 +413,9 @@ public class TextLayoutManager {
 
           // The attachment array returns the positions of each of the attachments as
           attachmentsPositions[attachmentPosition] =
-              (int) Math.ceil(PixelUtil.toSPFromPixel(placeholderTopPosition));
+              PixelUtil.toSPFromPixel(placeholderTopPosition);
           attachmentsPositions[attachmentPosition + 1] =
-              (int) Math.ceil(PixelUtil.toSPFromPixel(placeholderLeftPosition));
+              PixelUtil.toSPFromPixel(placeholderLeftPosition);
           attachmentIndex++;
         }
       }