RCTText should clip when the creates Layout is wider than requested

Summary: AbstractDrawCommand's bounds are supposed to be the rectangle that the DrawCommand will draw into, so that it can compare bounds against clip rect bounds and reliable skip clipping when it's not needed. It is however not true for RCTText that can create text Layout that in some cases can go out of it's requested bounds (happens with TextView, too). To fix the issue, instead of passing requested bounds, pass the actual ones. In this case, AbstractDrawCommand will make sure to clip DrawTextLayout if for some reason it draws outside of the allowed boundaries.

Reviewed By: ahmedre

Differential Revision: D2786306

ReactAndroid/src/main/java/com/facebook/react/flat/DrawTextLayout.java

@@ -18,9 +18,10 @@ import android.text.Layout;
 /* package */ final class DrawTextLayout extends AbstractDrawCommand {
 
   private Layout mLayout;
+  private float mLayoutWidth;
 
   /* package */ DrawTextLayout(Layout layout) {
-    mLayout = layout;
+    setLayout(layout);
   }
 
   /**
@@ -28,12 +29,30 @@ import android.text.Layout;
    */
   public void setLayout(Layout layout) {
     mLayout = layout;
+
+    // determine how wide we actually are
+    float maxLineWidth = 0;
+    int lineCount = layout.getLineCount();
+    for (int i = 0; i != lineCount; ++i) {
+      maxLineWidth = Math.max(maxLineWidth, layout.getLineMax(i));
+    }
+
+    mLayoutWidth = maxLineWidth;
   }
 
   public Layout getLayout() {
     return mLayout;
   }
 
+  public float getLayoutWidth() {
+    // mLayout.getWidth() doesn't return correct width of the text Layout
+    return mLayoutWidth;
+  }
+
+  public float getLayoutHeight() {
+    return mLayout.getHeight();
+  }
+
   @Override
   protected void onDraw(Canvas canvas) {
     float left = getLeft();