From e3a76c5155a005de34b76be006c3e961f8b6feb4 Mon Sep 17 00:00:00 2001
From: Moti Zilberman <moti@meta.com>
Date: Thu, 13 Jun 2024 12:22:48 -0700
Subject: [PATCH] Expose DevSettings.openDebugger method to JS (#44934)

Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/44934

Resubmission of D57681447 with an updated `ReactAndroid.api`.

 ---

Changelog: [Internal]

Adds a private API that gives JS the ability to trigger the same "open debugger" action as in the Dev Menu. This is in preparation for changes to LogBox.

For simplicity, this method operates on a best-effort basis - i.e. it doesn't report the success or failure (or failure reason) of the launch.

Reviewed By: huntie

Differential Revision: D58529832

fbshipit-source-id: e5510f529a19e0149d8dce04fa610e6c2371cc79
---
 .../react-native/React/CoreModules/RCTDevSettings.mm | 12 ++++++++++++
 .../react-native/ReactAndroid/api/ReactAndroid.api   |  2 ++
 .../react/modules/debug/DevSettingsModule.kt         |  4 ++++
 .../src/private/specs/modules/NativeDevSettings.js   |  1 +
 4 files changed, 19 insertions(+)

diff --git a/packages/react-native/React/CoreModules/RCTDevSettings.mm b/packages/react-native/React/CoreModules/RCTDevSettings.mm
index 887a69c06c1..d4e8473146e 100644
--- a/packages/react-native/React/CoreModules/RCTDevSettings.mm
+++ b/packages/react-native/React/CoreModules/RCTDevSettings.mm
@@ -501,6 +501,15 @@ RCT_EXPORT_METHOD(addMenuItem : (NSString *)title)
   }
 }
 
+RCT_EXPORT_METHOD(openDebugger)
+{
+#if RCT_ENABLE_INSPECTOR
+  [RCTInspectorDevServerHelper
+          openDebugger:self.bundleManager.bundleURL
+      withErrorMessage:@"Failed to open debugger. Please check that the dev server is running and reload the app."];
+#endif
+}
+
 #pragma mark - Internal
 
 /**
@@ -608,6 +617,9 @@ RCT_EXPORT_METHOD(addMenuItem : (NSString *)title)
 - (void)setupHMRClientWithAdditionalBundleURL:(NSURL *)bundleURL
 {
 }
+- (void)openDebugger
+{
+}
 - (void)addMenuItem:(NSString *)title
 {
 }
diff --git a/packages/react-native/ReactAndroid/api/ReactAndroid.api b/packages/react-native/ReactAndroid/api/ReactAndroid.api
index 3112b7cf36a..cad0f20e2ba 100644
--- a/packages/react-native/ReactAndroid/api/ReactAndroid.api
+++ b/packages/react-native/ReactAndroid/api/ReactAndroid.api
@@ -3215,6 +3215,7 @@ public final class com/facebook/react/modules/debug/DevSettingsModule : com/face
 	public fun addListener (Ljava/lang/String;)V
 	public fun addMenuItem (Ljava/lang/String;)V
 	public fun onFastRefresh ()V
+	public fun openDebugger ()V
 	public fun reload ()V
 	public fun reloadWithReason (Ljava/lang/String;)V
 	public fun removeListeners (D)V
@@ -3829,6 +3830,7 @@ public class com/facebook/react/runtime/ReactSurfaceImpl : com/facebook/react/in
 public final class com/facebook/react/runtime/ReactSurfaceView : com/facebook/react/ReactRootView {
 	public fun <init> (Landroid/content/Context;Lcom/facebook/react/runtime/ReactSurfaceImpl;)V
 	public fun getCurrentReactContext ()Lcom/facebook/react/bridge/ReactContext;
+	public fun getJSModuleName ()Ljava/lang/String;
 	public fun getUIManagerType ()I
 	public fun handleException (Ljava/lang/Throwable;)V
 	public fun hasActiveReactContext ()Z
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.kt
index 258f8042c5f..a482235ab83 100644
--- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.kt
+++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/modules/debug/DevSettingsModule.kt
@@ -61,6 +61,10 @@ public class DevSettingsModule(
     }
   }
 
+  override fun openDebugger() {
+    devSupportManager.openDebugger()
+  }
+
   override fun setIsShakeToShowDevMenuEnabled(enabled: Boolean) {
     // iOS only
   }
diff --git a/packages/react-native/src/private/specs/modules/NativeDevSettings.js b/packages/react-native/src/private/specs/modules/NativeDevSettings.js
index 26085ad6bc3..2afb1d54f36 100644
--- a/packages/react-native/src/private/specs/modules/NativeDevSettings.js
+++ b/packages/react-native/src/private/specs/modules/NativeDevSettings.js
@@ -21,6 +21,7 @@ export interface Spec extends TurboModule {
   +setProfilingEnabled: (isProfilingEnabled: boolean) => void;
   +toggleElementInspector: () => void;
   +addMenuItem: (title: string) => void;
+  +openDebugger?: () => void;
 
   // Events
   +addListener: (eventName: string) => void;