From e0935e645d02e8dd7ff77742e2f3d426eaa2b776 Mon Sep 17 00:00:00 2001 From: Alex Hunt Date: Thu, 5 Feb 2026 11:06:06 -0800 Subject: [PATCH] Update test_js job to be dependent on lint (#55428) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/55428 With a lighter weight `lint` job, make this blocking for `test_js` runs. The combined `lint` + `test_js` execution time in series remains far less than the native build+test jobs. Changelog: [Internal] Reviewed By: cortinico Differential Revision: D92417805 fbshipit-source-id: 05832257518c8141ca0955f18e740f752e675d4d --- .github/workflows/test-all.yml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index 4a95d5222c7..79dec9cfd0e 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -486,21 +486,6 @@ jobs: flavor: ${{ matrix.flavor }} use-frameworks: ${{ matrix.use_frameworks }} - test_js: - runs-on: ubuntu-latest - if: github.repository == 'facebook/react-native' - strategy: - fail-fast: false - matrix: - node-version: ["24", "22", "20.19.4"] - steps: - - name: Checkout - uses: actions/checkout@v6 - - name: Test JS - uses: ./.github/actions/test-js - with: - node-version: ${{ matrix.node-version }} - lint: runs-on: ubuntu-latest if: github.repository == 'facebook/react-native' @@ -531,6 +516,21 @@ jobs: shell: bash run: yarn test-typescript + test_js: + runs-on: ubuntu-latest + needs: lint + strategy: + fail-fast: false + matrix: + node-version: ["24", "22", "20.19.4"] + steps: + - name: Checkout + uses: actions/checkout@v6 + - name: Test JS + uses: ./.github/actions/test-js + with: + node-version: ${{ matrix.node-version }} + build_js_types: runs-on: ubuntu-latest needs: lint