Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove useOverflowInset flag as we rolled out 100% to public for over three months

Browse Source 
Summary:
Remove overflow inset optimization flags as they've been rolled out 100% to public.

Changelog:
[Android][Internal] - Clean up feature flags for overflowInset

Reviewed By: nlutsenko

Differential Revision: D36990986

fbshipit-source-id: 77da78a2927034893f25937c2ccbd0b53e08031d
This commit is contained in:
Xin Chen
2022-06-09 12:30:14 -07:00
committed by Facebook GitHub Bot
parent d592bdcbd3
commit df80ed40c7
4 changed files with 4 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/config/ReactFeatureFlags.java
-3
View File
@@ -83,9 +83,6 @@ public class ReactFeatureFlags {
/** Enables or disables MapBuffer Serialization */
public static boolean mapBufferSerializationEnabled = false;
/** Feature Flag to use overflowInset values provided by Yoga */
public static boolean useOverflowInset = false;
public static boolean enableLockFreeEventDispatcher = false;
public static boolean enableAggressiveEventEmitterCleanup = false;
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/FabricMountingManager.cpp
+4 -7
View File
@@ -46,7 +46,6 @@ FabricMountingManager::FabricMountingManager(
config->getBool("react_fabric:disabled_view_preallocation_android")),
disableRevisionCheckForPreallocation_(config->getBool(
"react_fabric:disable_revision_check_for_preallocation")),
useOverflowInset_(getFeatureFlagValue("useOverflowInset")),
shouldRememberAllocatedViews_(
getFeatureFlagValue("shouldRememberAllocatedViews")),
useMapBufferForViewProps_(config->getBool(
@@ -376,9 +375,8 @@ void FabricMountingManager::executeMount(
// children of the current view. The layout of current view may not
// change, and we separate this part from layout mount items to not
// pack too much data there.
if (useOverflowInset_ &&
(oldChildShadowView.layoutMetrics.overflowInset !=
newChildShadowView.layoutMetrics.overflowInset)) {
if (oldChildShadowView.layoutMetrics.overflowInset !=
newChildShadowView.layoutMetrics.overflowInset) {
cppUpdateOverflowInsetMountItems.push_back(
CppMountItem::UpdateOverflowInsetMountItem(
newChildShadowView));
@@ -435,9 +433,8 @@ void FabricMountingManager::executeMount(
// children of the current view. The layout of current view may not
// change, and we separate this part from layout mount items to not
// pack too much data there.
if (useOverflowInset_ &&
newChildShadowView.layoutMetrics.overflowInset !=
EdgeInsets::ZERO) {
if (newChildShadowView.layoutMetrics.overflowInset !=
EdgeInsets::ZERO) {
cppUpdateOverflowInsetMountItems.push_back(
CppMountItem::UpdateOverflowInsetMountItem(
newChildShadowView));
ReactAndroid/src/main/java/com/facebook/react/fabric/jni/FabricMountingManager.h
-1
View File
@@ -72,7 +72,6 @@ class FabricMountingManager final {
bool const enableEarlyEventEmitterUpdate_{false};
bool const disablePreallocateViews_{false};
bool const disableRevisionCheckForPreallocation_{false};
bool const useOverflowInset_{false};
bool const shouldRememberAllocatedViews_{false};
bool const useMapBufferForViewProps_{false};
ReactAndroid/src/main/java/com/facebook/react/uimanager/TouchTargetHelper.java
-2
View File
@@ -19,7 +19,6 @@ import android.view.ViewGroup;
import androidx.annotation.Nullable;
import com.facebook.react.bridge.JSApplicationIllegalArgumentException;
import com.facebook.react.bridge.UiThreadUtil;
import com.facebook.react.config.ReactFeatureFlags;
import com.facebook.react.touch.ReactHitSlopView;
import com.facebook.react.uimanager.common.ViewUtil;
import java.util.ArrayList;
@@ -192,7 +191,6 @@ public class TouchTargetHelper {
// If the touch point is outside of the overflowinset for the view, we can safely ignore
// it.
if (ViewUtil.getUIManagerType(view.getId()) == FABRIC
&& ReactFeatureFlags.useOverflowInset
&& !isTouchPointInViewWithOverflowInset(eventCoords[0], eventCoords[1], view)) {
return null;
}