From df0bfec2012b4a1c10a3747ab646bcd4597d2e21 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Thu, 17 Dec 2020 10:11:05 -0800 Subject: [PATCH] Round 2: Remove synthesize bridge = _bridge Summary: All NativeModules that used to use the bridge to require other NativeModules now require other NativeModules via the Venice-compatible RCTModuleRegistry abstraction. Therefore, we can safely get rid of synthesize bridge = _bridge from them. ## How did I generate this diff? 1. Search for all NativeModules that have `synthesize bridge =` 2. Remove the `synthesize bridge = _bridge` from each NativeModule, and if it doesn't contain `_bridge`, `setBridge:`, or `elf.bridge`, add it to this codemod. Changelog: [Internal] Reviewed By: PeteTheHeat Differential Revision: D25551295 fbshipit-source-id: 585d50ad55cb9ab083e430b07e1cf30e31f0d3c5 --- Libraries/Blob/RCTFileReaderModule.mm | 1 - Libraries/Image/RCTImageEditingManager.mm | 1 - Libraries/Network/RCTHTTPRequestHandler.mm | 1 - Libraries/Settings/RCTSettingsManager.mm | 1 - React/CoreModules/RCTDeviceInfo.mm | 1 - React/CoreModules/RCTExceptionsManager.mm | 1 - 6 files changed, 6 deletions(-) diff --git a/Libraries/Blob/RCTFileReaderModule.mm b/Libraries/Blob/RCTFileReaderModule.mm index 715a3457537..2525de0c201 100644 --- a/Libraries/Blob/RCTFileReaderModule.mm +++ b/Libraries/Blob/RCTFileReaderModule.mm @@ -23,7 +23,6 @@ RCT_EXPORT_MODULE(FileReaderModule) -@synthesize bridge = _bridge; @synthesize moduleRegistry = _moduleRegistry; RCT_EXPORT_METHOD(readAsText:(NSDictionary *)blob diff --git a/Libraries/Image/RCTImageEditingManager.mm b/Libraries/Image/RCTImageEditingManager.mm index 742e1b5eee1..47b2f60f849 100644 --- a/Libraries/Image/RCTImageEditingManager.mm +++ b/Libraries/Image/RCTImageEditingManager.mm @@ -26,7 +26,6 @@ RCT_EXPORT_MODULE() -@synthesize bridge = _bridge; @synthesize moduleRegistry = _moduleRegistry; /** diff --git a/Libraries/Network/RCTHTTPRequestHandler.mm b/Libraries/Network/RCTHTTPRequestHandler.mm index 8018f028c7c..6b1f240daa4 100644 --- a/Libraries/Network/RCTHTTPRequestHandler.mm +++ b/Libraries/Network/RCTHTTPRequestHandler.mm @@ -25,7 +25,6 @@ std::mutex _mutex; } -@synthesize bridge = _bridge; @synthesize moduleRegistry = _moduleRegistry; @synthesize methodQueue = _methodQueue; diff --git a/Libraries/Settings/RCTSettingsManager.mm b/Libraries/Settings/RCTSettingsManager.mm index 1adf33c4477..585d60aee22 100644 --- a/Libraries/Settings/RCTSettingsManager.mm +++ b/Libraries/Settings/RCTSettingsManager.mm @@ -24,7 +24,6 @@ NSUserDefaults *_defaults; } -@synthesize bridge = _bridge; @synthesize moduleRegistry = _moduleRegistry; RCT_EXPORT_MODULE() diff --git a/React/CoreModules/RCTDeviceInfo.mm b/React/CoreModules/RCTDeviceInfo.mm index 6084c9ffeaf..f470f99572e 100644 --- a/React/CoreModules/RCTDeviceInfo.mm +++ b/React/CoreModules/RCTDeviceInfo.mm @@ -27,7 +27,6 @@ using namespace facebook::react; NSDictionary *_currentInterfaceDimensions; } -@synthesize bridge = _bridge; @synthesize moduleRegistry = _moduleRegistry; @synthesize turboModuleRegistry = _turboModuleRegistry; diff --git a/React/CoreModules/RCTExceptionsManager.mm b/React/CoreModules/RCTExceptionsManager.mm index e45b270031f..175c5612cff 100644 --- a/React/CoreModules/RCTExceptionsManager.mm +++ b/React/CoreModules/RCTExceptionsManager.mm @@ -23,7 +23,6 @@ @implementation RCTExceptionsManager -@synthesize bridge = _bridge; @synthesize moduleRegistry = _moduleRegistry; RCT_EXPORT_MODULE()