Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Test setting layout params to wrap_content for fix text layout bug

Browse Source 
Summary:
Changelog:
[Android][Fixed] -  Fix layout bug in ReactTextView.

Reviewed By: mdvacca

Differential Revision: D26752392

fbshipit-source-id: eeb9c16a4165b4d9329534981925621ae51a7dcb
This commit is contained in:
Lulu Wu
2021-03-02 10:43:55 -08:00
committed by Facebook GitHub Bot
parent 62fcb4e22c
commit dec1b6ba15
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextView.java
+11 -5
View File
@@ -48,6 +48,10 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie
private static final ViewGroup.LayoutParams EMPTY_LAYOUT_PARAMS =
new ViewGroup.LayoutParams(0, 0);
private static final ViewGroup.LayoutParams WRAP_CONTENT_LAYOUT_PARAMS =
new ViewGroup.LayoutParams(
ViewGroup.LayoutParams.WRAP_CONTENT, ViewGroup.LayoutParams.WRAP_CONTENT);
private boolean mContainsImages;
private int mDefaultGravityHorizontal;
private int mDefaultGravityVertical;
@@ -266,12 +270,14 @@ public class ReactTextView extends AppCompatTextView implements ReactCompoundVie
public void setText(ReactTextUpdate update) {
mContainsImages = update.containsImages();
if (ReactFeatureFlags.enableSettingEmptyLayoutParams) {
// Android's TextView crashes when it tries to relayout if LayoutParams are
// null; explicitly set the LayoutParams to prevent this crash. See:
// https://github.com/facebook/react-native/pull/7011
if (getLayoutParams() == null) {
// Android's TextView crashes when it tries to relayout if LayoutParams are
// null; explicitly set the LayoutParams to prevent this crash. See:
// https://github.com/facebook/react-native/pull/7011
if (getLayoutParams() == null) {
if (ReactFeatureFlags.enableSettingEmptyLayoutParams) {
setLayoutParams(EMPTY_LAYOUT_PARAMS);
} else {
setLayoutParams(WRAP_CONTENT_LAYOUT_PARAMS);
}
}
Spannable spannable = update.getText();