From de57be51d017a20727164e0d971a4ea049cb258e Mon Sep 17 00:00:00 2001 From: Samuel Susla Date: Wed, 10 Jun 2026 09:17:52 -0700 Subject: [PATCH] Remove dead StartupLogger::getRunJSBundleEndTime getter Summary: X-link: https://github.com/facebook/react-native/pull/57142 `StartupLogger::getRunJSBundleEndTime()` was a public getter that returned the `runJSBundleEndTime` member, but it had no callers. `NativePerformance` is the only consumer of `StartupLogger` and reads the start-time getters plus `getAppStartupEndTime`, never this end-time getter. This removes the dead getter. The backing member `runJSBundleEndTime` is kept because `logStartupEvent`/`reset` still write it. Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D108012912 fbshipit-source-id: ac6348b8223fba8695843340e99d7e277bf4f60a --- packages/react-native/ReactCommon/cxxreact/ReactMarker.cpp | 4 ---- packages/react-native/ReactCommon/cxxreact/ReactMarker.h | 1 - scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api | 1 - scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api | 1 - 11 files changed, 14 deletions(-) diff --git a/packages/react-native/ReactCommon/cxxreact/ReactMarker.cpp b/packages/react-native/ReactCommon/cxxreact/ReactMarker.cpp index dcd6d420803..fe9423ca3b3 100644 --- a/packages/react-native/ReactCommon/cxxreact/ReactMarker.cpp +++ b/packages/react-native/ReactCommon/cxxreact/ReactMarker.cpp @@ -110,10 +110,6 @@ double StartupLogger::getRunJSBundleStartTime() { return runJSBundleStartTime; } -double StartupLogger::getRunJSBundleEndTime() { - return runJSBundleEndTime; -} - double StartupLogger::getAppStartupEndTime() { return appStartupEndTime; } diff --git a/packages/react-native/ReactCommon/cxxreact/ReactMarker.h b/packages/react-native/ReactCommon/cxxreact/ReactMarker.h index 31b01d83c9c..83a26a5a6f9 100644 --- a/packages/react-native/ReactCommon/cxxreact/ReactMarker.h +++ b/packages/react-native/ReactCommon/cxxreact/ReactMarker.h @@ -95,7 +95,6 @@ class RN_EXPORT StartupLogger { double getInitReactRuntimeStartTime(); double getInitReactRuntimeEndTime(); double getRunJSBundleStartTime(); - double getRunJSBundleEndTime(); double getAppStartupEndTime(); private: diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index c397fe34d92..ee63fec08e2 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -11716,7 +11716,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api index 15af52e85c1..d226a594416 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api @@ -11342,7 +11342,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index 67218a64c80..887f267ed6e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -11569,7 +11569,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime); diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index 513770ccd3b..c2e44eafd95 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -13547,7 +13547,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime); diff --git a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api index 6fe831004af..98cb0029781 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api @@ -13235,7 +13235,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime); diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index 91c526cadd8..536cb43a6e6 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -13410,7 +13410,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime); diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index 27455fe089b..c0a08752a67 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -8701,7 +8701,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime); diff --git a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api index 9cc07759abe..841fb24cf5b 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api @@ -8529,7 +8529,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime); diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index 386592ab412..0f235408a59 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -8692,7 +8692,6 @@ class facebook::react::ReactMarker::StartupLogger { public double getAppStartupStartTime(); public double getInitReactRuntimeEndTime(); public double getInitReactRuntimeStartTime(); - public double getRunJSBundleEndTime(); public double getRunJSBundleStartTime(); public static facebook::react::ReactMarker::StartupLogger& getInstance(); public void logStartupEvent(facebook::react::ReactMarker::ReactMarkerId markerId, double markerTime);