From de56fb6309205a18c7b60baa113261e0d208c68b Mon Sep 17 00:00:00 2001 From: Nick Lefever Date: Mon, 7 Oct 2024 06:11:36 -0700 Subject: [PATCH] Enable shadow node reference updates by default (#46823) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46823 Changelog: [Internal] Releasing runtime shadow node reference updates, enabling it by default. Reviewed By: shwanton, rubennorte Differential Revision: D63829891 fbshipit-source-id: 9292df3f8c7c8986d8e06d3c526ad1e6e8773916 --- .../internal/featureflags/ReactNativeFeatureFlagsDefaults.kt | 4 ++-- .../react/featureflags/ReactNativeFeatureFlagsDefaults.h | 4 ++-- .../scripts/featureflags/ReactNativeFeatureFlags.config.js | 2 +- .../src/private/featureflags/ReactNativeFeatureFlags.js | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt index c899fdbe81e..9463cae9846 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeFeatureFlagsDefaults.kt @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<36b028f86ee9985386f7c1a8a576e348>> */ /** @@ -113,7 +113,7 @@ public open class ReactNativeFeatureFlagsDefaults : ReactNativeFeatureFlagsProvi override fun useOptimizedEventBatchingOnAndroid(): Boolean = false - override fun useRuntimeShadowNodeReferenceUpdate(): Boolean = false + override fun useRuntimeShadowNodeReferenceUpdate(): Boolean = true override fun useRuntimeShadowNodeReferenceUpdateOnLayout(): Boolean = false diff --git a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h index 33c58ce6ed2..35e6e08da06 100644 --- a/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h +++ b/packages/react-native/ReactCommon/react/featureflags/ReactNativeFeatureFlagsDefaults.h @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<> */ /** @@ -208,7 +208,7 @@ class ReactNativeFeatureFlagsDefaults : public ReactNativeFeatureFlagsProvider { } bool useRuntimeShadowNodeReferenceUpdate() override { - return false; + return true; } bool useRuntimeShadowNodeReferenceUpdateOnLayout() override { diff --git a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js index 8acaebeaa1f..83c501beb5d 100644 --- a/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js +++ b/packages/react-native/scripts/featureflags/ReactNativeFeatureFlags.config.js @@ -423,7 +423,7 @@ const definitions: FeatureFlagDefinitions = { }, }, useRuntimeShadowNodeReferenceUpdate: { - defaultValue: false, + defaultValue: true, metadata: { dateAdded: '2024-06-03', description: diff --git a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js index 37a0375094f..43110609e8f 100644 --- a/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js +++ b/packages/react-native/src/private/featureflags/ReactNativeFeatureFlags.js @@ -4,7 +4,7 @@ * This source code is licensed under the MIT license found in the * LICENSE file in the root directory of this source tree. * - * @generated SignedSource<> + * @generated SignedSource<<63f5264a08dcd36d44b7574d908b6d42>> * @flow strict */ @@ -369,7 +369,7 @@ export const useOptimizedEventBatchingOnAndroid: Getter = createNativeF /** * When enabled, cloning shadow nodes within react native will update the reference held by the current JS fiber tree. */ -export const useRuntimeShadowNodeReferenceUpdate: Getter = createNativeFlagGetter('useRuntimeShadowNodeReferenceUpdate', false); +export const useRuntimeShadowNodeReferenceUpdate: Getter = createNativeFlagGetter('useRuntimeShadowNodeReferenceUpdate', true); /** * When enabled, cloning shadow nodes during layout will update the reference held by the current JS fiber tree. */