Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update InitialLifeCycleState used when initializing RN in FB4A

Browse Source 
Summary:
This diff changes the InitialLifeCycleState used when initializing RN in FB4A from BEFORE_RESUME to BEFORE_CREATE.
The value of this field is used during the teardown of RN to determine if RN is actually running or not

The intention of this change is to represent the right behavior of RN during initialization, also this will allow RN to be turn down in case of memory pressure when the bridge has been initialized but before the user has navigated to a RN screen (preloading)

changelog: [internal]

Reviewed By: JoshuaGross

Differential Revision: D22577555

fbshipit-source-id: e54ef596cfe4429745611fe6022eb000051a93d0
This commit is contained in:
David Vacca
2020-07-16 14:47:52 -07:00
committed by Facebook GitHub Bot
parent e629e94b46
commit de094396e3
1 changed files with 9 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
ReactAndroid/src/main/java/com/facebook/react/common/LifecycleState.java
+9 -2
View File
@@ -10,9 +10,16 @@ package com.facebook.react.common;
/**
* Lifecycle state for an Activity. The state right after pause and right before resume are the
* basically the same so this enum is in terms of the forward lifecycle progression (onResume, etc).
* Eventually, if necessary, it could contain something like:
*
* <p>BEFORE_CREATE, CREATED, VIEW_CREATED, STARTED, RESUMED
* <p>BEFORE_CREATE is used before a ReactRootView is attached to ReactInstanceManager, or after all
* the ReactRootView has been detached from the ReactInstanceManager.
*
* <p>BEFORE_RESUME is used after a ReactRootView is attached to ReactInstanceManager but before
* it's activity is resumed, or after its activity has been paused and before the ReactRootView has
* been detached from the ReactInstanceManager.
*
* <p>RESUMED is used when a ReactRootView is rendered on the screen and the user can interact with
* it.
*/
public enum LifecycleState {
BEFORE_CREATE,