From ddfa2120ba4d5e1f39b668ae7545a096616f657d Mon Sep 17 00:00:00 2001 From: Nicola Corti Date: Fri, 6 Dec 2024 12:05:53 -0800 Subject: [PATCH] Cleanup NoRetryPolicy unnecessary visibility. (#48146) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/48146 The NoRetryPolicy class is `internal`. Having those `public` modifiers on methods has no effect and can be safely removed. Changelog: [Internal] [Changed] - Reviewed By: fabriziocucci Differential Revision: D66875443 fbshipit-source-id: 64c63c7000617cf94c36ce3d25927d3a270ac370 --- .../java/com/facebook/react/jstasks/NoRetryPolicy.kt | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/jstasks/NoRetryPolicy.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/jstasks/NoRetryPolicy.kt index df245683fd8..2e6223c66a9 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/jstasks/NoRetryPolicy.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/jstasks/NoRetryPolicy.kt @@ -9,20 +9,20 @@ package com.facebook.react.jstasks internal class NoRetryPolicy private constructor() : HeadlessJsTaskRetryPolicy { - override public fun canRetry(): Boolean = false + override fun canRetry(): Boolean = false - override public fun getDelay(): Int { + override fun getDelay(): Int { throw IllegalStateException("Should not retrieve delay as canRetry is: ${canRetry()}") } - override public fun update(): HeadlessJsTaskRetryPolicy { + override fun update(): HeadlessJsTaskRetryPolicy { throw IllegalStateException("Should not update as canRetry is: ${canRetry()}") } // Class is immutable so no need to copy - override public fun copy(): HeadlessJsTaskRetryPolicy = this + override fun copy(): HeadlessJsTaskRetryPolicy = this - public companion object { - @JvmField public val INSTANCE: NoRetryPolicy = NoRetryPolicy() + companion object { + @JvmField val INSTANCE: NoRetryPolicy = NoRetryPolicy() } }