From dd49f9e0bc10cf3bc4cc86015823c4a7a6e297ae Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Tue, 10 Apr 2018 16:37:16 -0700 Subject: [PATCH] Fabric: Fixed incorrect usage of `Undefined` (instead of `kFloatUndefined`) in `yogaValuesConversions` Summary: `Undefined` is actually equal `0` (becasuse it is `LayoutDirection::Undefined`), whereas `kFloatUndefined` is a magic huge number. Reviewed By: fkgozali Differential Revision: D7554550 fbshipit-source-id: 3ea37f0b8b6a59b4b0e00d205b75cd7252247d03 --- ReactCommon/fabric/view/yoga/yogaValuesConversions.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ReactCommon/fabric/view/yoga/yogaValuesConversions.cpp b/ReactCommon/fabric/view/yoga/yogaValuesConversions.cpp index e780d2cecd6..05137f5e92b 100644 --- a/ReactCommon/fabric/view/yoga/yogaValuesConversions.cpp +++ b/ReactCommon/fabric/view/yoga/yogaValuesConversions.cpp @@ -16,14 +16,14 @@ namespace react { Float fabricFloatFromYogaFloat(float value) { if (value == YGUndefined) { - return Undefined; + return kFloatUndefined; } return (Float)value; } float yogaFloatFromFabricFloat(Float value) { - if (value == Undefined) { + if (value == kFloatUndefined) { return YGUndefined; }