Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove duplicated jobs in CircleCI (#41698)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/41698

With the previous changes on the Pod configuration, the build setup for the New and Old architecture are the same.
The only observable difference happens at runtime.

This change:
1. Removes the build job that are split by architecture (which is now duplicated work)
2. Add two more test jobs to run runtime tests (unit and integration test) to make sure that the two architectures continue working.

## Changelog:
[Internal] - [CI] Remove duplicated build jobs, add tests jobs

Reviewed By: cortinico

Differential Revision: D51659275

fbshipit-source-id: 769c9ee004e7f4f1a7444f39c02b7083e007b780
This commit is contained in:
Riccardo Cipolleschi
2023-11-29 04:17:48 -08:00
committed by Facebook GitHub Bot
parent 4a35f2512e
commit dc95568375
2 changed files with 14 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files
.circleci/configurations/test_workflows/testAll.yml
+7 -11
View File
@@ -62,18 +62,17 @@
flavor: "Debug"
executor: reactnativeios-lts
- test_ios_template:
architecture: "OldArch"
requires:
- build_npm_package
matrix:
parameters:
architecture: ["NewArch", "OldArch"]
flavor: ["Debug", "Release"]
jsengine: ["Hermes", "JSC"]
use_frameworks: ["StaticLibraries", "DynamicFrameworks"]
exclude:
# This config is tested with Ruby 3.2.0. Let's not double test it.
- architecture: "NewArch"
flavor: "Debug"
- flavor: "Debug"
jsengine: "Hermes"
use_frameworks: "StaticLibraries"
- test_ios_rntester:
@@ -84,33 +83,30 @@
architecture: "NewArch"
executor: reactnativeios-lts
- test_ios_rntester:
architecture: "NewArch"
requires:
- build_hermes_macos
matrix:
parameters:
architecture: ["NewArch", "OldArch"]
jsengine: ["Hermes", "JSC"]
use_frameworks: ["StaticLibraries", "DynamicFrameworks"]
exclude:
# Tested by test_ios-Hermes
- architecture: "OldArch"
jsengine: "Hermes"
- jsengine: "Hermes"
use_frameworks: "StaticLibraries"
# Tested by test_ios-JSC
- architecture: "OldArch"
jsengine: "JSC"
- jsengine: "JSC"
use_frameworks: "StaticLibraries"
# Tested with Ruby 3.2.0, do not test this twice.
- architecture: "NewArch"
jsengine: "Hermes"
- jsengine: "Hermes"
use_frameworks: "StaticLibraries"
- test_ios_rntester:
run_unit_tests: true
architecture: "OldArch"
use_frameworks: "StaticLibraries"
ruby_version: "2.6.10"
requires:
- build_hermes_macos
matrix:
parameters:
architecture: ["OldArch", "NewArch"]
jsengine: ["Hermes", "JSC"]
.circleci/configurations/test_workflows/testIOS.yml
+7 -11
View File
@@ -53,18 +53,17 @@
flavor: "Debug"
executor: reactnativeios-lts
- test_ios_template:
architecture: "OldArch"
requires:
- build_npm_package
matrix:
parameters:
architecture: ["NewArch", "OldArch"]
flavor: ["Debug", "Release"]
jsengine: ["Hermes", "JSC"]
use_frameworks: ["StaticLibraries", "DynamicFrameworks"]
exclude:
# Tested with Ruby 3.2.0, let's not double test this
- architecture: "NewArch"
flavor: "Debug"
- flavor: "Debug"
jsengine: "Hermes"
use_frameworks: "StaticLibraries"
- test_ios_rntester:
@@ -75,33 +74,30 @@
architecture: "NewArch"
executor: reactnativeios-lts
- test_ios_rntester:
architecture: "NewArch"
requires:
- build_hermes_macos
matrix:
parameters:
architecture: ["NewArch", "OldArch"]
jsengine: ["Hermes", "JSC"]
use_frameworks: ["StaticLibraries", "DynamicFrameworks"]
exclude:
# Tested by test_ios-Hermes
- architecture: "OldArch"
jsengine: "Hermes"
- jsengine: "Hermes"
use_frameworks: "StaticLibraries"
# Tested by test_ios-JSC
- architecture: "OldArch"
jsengine: "JSC"
- jsengine: "JSC"
use_frameworks: "StaticLibraries"
# Tested with Ruby 3.2.0, let's not double test this
- architecture: "NewArch"
jsengine: "Hermes"
- jsengine: "Hermes"
use_frameworks: "StaticLibraries"
- test_ios_rntester:
run_unit_tests: true
architecture: "OldArch"
use_frameworks: "StaticLibraries"
ruby_version: "2.6.10"
requires:
- build_hermes_macos
matrix:
parameters:
architecture: ["NewArch", "OldArch"]
jsengine: ["Hermes", "JSC"]