From dc5110a8f288dcf6422d4845ce5fac2fcf43b471 Mon Sep 17 00:00:00 2001 From: Riccardo Cipolleschi Date: Fri, 11 Jul 2025 07:15:35 -0700 Subject: [PATCH] Unify test_ios_rntester_dynamic_frameworks with test_ios_rntester (#52563) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/52563 The test_ios_rntester_dynamic_frameworks is identical to the test_ios_rntester but for the framework parameter. This change unifies the two, using a matrix to test all the configurations: - Debug / Static Libraries - Release / Static Libraries - Debug / Dynamic Frameworks - Release / Dynamic Frameworks ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D78159366 fbshipit-source-id: b321f295477fe3ae6e43c7518d47afb0714bddb8 --- .github/workflows/test-all.yml | 25 +++---------------------- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/.github/workflows/test-all.yml b/.github/workflows/test-all.yml index e4da3cec69c..cd837dbc3ab 100644 --- a/.github/workflows/test-all.yml +++ b/.github/workflows/test-all.yml @@ -141,26 +141,7 @@ jobs: ruby-version: "3.2.0" hermes-version: ${{ needs.prepare_hermes_workspace.outputs.hermes-version }} react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }} - - test_ios_rntester_dynamic_frameworks: - runs-on: macos-14 - needs: - [build_apple_slices_hermes, prepare_hermes_workspace, build_hermes_macos, prebuild_apple_dependencies] - env: - HERMES_WS_DIR: /tmp/hermes - HERMES_TARBALL_ARTIFACTS_DIR: /tmp/hermes/hermes-runtime-darwin - continue-on-error: true - strategy: - fail-fast: false - steps: - - name: Checkout - uses: actions/checkout@v4 - - name: Run it - uses: ./.github/actions/test-ios-rntester - with: - use-frameworks: DynamicFrameworks - hermes-version: ${{ needs.prepare_hermes_workspace.outputs.hermes-version }} - react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }} + flavor: Debug test_ios_rntester: runs-on: macos-14-large @@ -174,14 +155,14 @@ jobs: fail-fast: false matrix: flavor: [Debug, Release] + frameworks: [StaticLibraries, DynamicFrameworks] steps: - name: Checkout uses: actions/checkout@v4 - name: Run it uses: ./.github/actions/test-ios-rntester with: - run-unit-tests: "false" - use-frameworks: StaticLibraries + use-frameworks: ${{ matrix.frameworks }} hermes-version: ${{ needs.prepare_hermes_workspace.outputs.hermes-version }} react-native-version: ${{ needs.prepare_hermes_workspace.outputs.react-native-version }} flavor: ${{ matrix.flavor }}