Facebook/react-native
1
0
Fork 0
mirror of https://github.com/facebook/react-native.git synced 2025-11-01 09:14:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove support for Android API < 23 in ReactTextInputShadowNode (#39686)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/react-native/pull/39686

Since minsdk version was increased to 23, we are deleting code using Android APIs < 23 for class ReactTextInputShadowNode

changelog: [Android][Breaking] Remove support for Android API < 23 in ReactTextInputShadowNode

Reviewed By: NickGerleman

Differential Revision: D48545503

fbshipit-source-id: f3b4fb696c3abf1f20ab00a89e786b3787c1b0e9
This commit is contained in:
David Vacca
2023-09-29 12:11:24 -07:00
committed by Facebook GitHub Bot
parent b968cb6f97
commit dc3fc16ce5
1 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/textinput/ReactTextInputShadowNode.java
+2 -13
View File
@@ -7,8 +7,6 @@
package com.facebook.react.views.textinput;
import android.annotation.TargetApi;
import android.os.Build;
import android.text.Layout;
import android.util.TypedValue;
import android.view.ViewGroup;
@@ -35,7 +33,6 @@ import com.facebook.yoga.YogaMeasureOutput;
import com.facebook.yoga.YogaNode;
@VisibleForTesting
@TargetApi(Build.VERSION_CODES.M)
public class ReactTextInputShadowNode extends ReactBaseTextShadowNode
implements YogaMeasureFunction {
@@ -53,10 +50,7 @@ public class ReactTextInputShadowNode extends ReactBaseTextShadowNode
public ReactTextInputShadowNode(
@Nullable ReactTextViewManagerCallback reactTextViewManagerCallback) {
super(reactTextViewManagerCallback);
mTextBreakStrategy =
(Build.VERSION.SDK_INT < Build.VERSION_CODES.M)
? Layout.BREAK_STRATEGY_SIMPLE
: Layout.BREAK_STRATEGY_HIGH_QUALITY;
mTextBreakStrategy = Layout.BREAK_STRATEGY_HIGH_QUALITY;
initMeasureFunction();
}
@@ -118,8 +112,7 @@ public class ReactTextInputShadowNode extends ReactBaseTextShadowNode
editText.setLines(mNumberOfLines);
}
if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M
&& editText.getBreakStrategy() != mTextBreakStrategy) {
if (editText.getBreakStrategy() != mTextBreakStrategy) {
editText.setBreakStrategy(mTextBreakStrategy);
}
}
@@ -182,10 +175,6 @@ public class ReactTextInputShadowNode extends ReactBaseTextShadowNode
@Override
public void setTextBreakStrategy(@Nullable String textBreakStrategy) {
if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) {
return;
}
if (textBreakStrategy == null || "simple".equals(textBreakStrategy)) {
mTextBreakStrategy = Layout.BREAK_STRATEGY_SIMPLE;
} else if ("highQuality".equals(textBreakStrategy)) {