diff --git a/Libraries/CameraRoll/RCTImagePickerManager.mm b/Libraries/CameraRoll/RCTImagePickerManager.mm index 1c3a76488a9..5180a1365bd 100644 --- a/Libraries/CameraRoll/RCTImagePickerManager.mm +++ b/Libraries/CameraRoll/RCTImagePickerManager.mm @@ -59,11 +59,6 @@ RCT_EXPORT_MODULE(ImagePickerIOS); return NO; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self name:@"AVCaptureDeviceDidStartRunningNotification" object:nil]; -} - - (dispatch_queue_t)methodQueue { return dispatch_get_main_queue(); diff --git a/Libraries/Image/RCTAnimatedImage.m b/Libraries/Image/RCTAnimatedImage.m index 210218b7845..cd15c92a178 100644 --- a/Libraries/Image/RCTAnimatedImage.m +++ b/Libraries/Image/RCTAnimatedImage.m @@ -164,7 +164,6 @@ CFRelease(_imageSource); _imageSource = NULL; } - [[NSNotificationCenter defaultCenter] removeObserver:self name:UIApplicationDidReceiveMemoryWarningNotification object:nil]; } @end diff --git a/Libraries/Image/RCTImageCache.m b/Libraries/Image/RCTImageCache.m index 248550743e8..e485e806e77 100644 --- a/Libraries/Image/RCTImageCache.m +++ b/Libraries/Image/RCTImageCache.m @@ -54,11 +54,6 @@ static NSString *RCTCacheKeyForImage(NSString *imageTag, CGSize size, CGFloat sc return self; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - - (void)clearCache { [_decodedImageCache removeAllObjects]; diff --git a/Libraries/Image/RCTImageView.m b/Libraries/Image/RCTImageView.m index 64824d428af..a55857d083c 100644 --- a/Libraries/Image/RCTImageView.m +++ b/Libraries/Image/RCTImageView.m @@ -103,11 +103,6 @@ static NSDictionary *onLoadParamsForSource(RCTImageSource *source) return self; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - RCT_NOT_IMPLEMENTED(- (instancetype)init) RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)aDecoder) diff --git a/Libraries/Image/RCTUIImageViewAnimated.m b/Libraries/Image/RCTUIImageViewAnimated.m index 1caee8300da..21f1a065b31 100644 --- a/Libraries/Image/RCTUIImageViewAnimated.m +++ b/Libraries/Image/RCTUIImageViewAnimated.m @@ -311,7 +311,6 @@ static NSUInteger RCTDeviceFreeMemory() { // Removes the display link from all run loop modes. [_displayLink invalidate]; _displayLink = nil; - [[NSNotificationCenter defaultCenter] removeObserver:self name:UIApplicationDidReceiveMemoryWarningNotification object:nil]; } - (void)didReceiveMemoryWarning:(NSNotification *)notification diff --git a/Libraries/Settings/RCTSettingsManager.mm b/Libraries/Settings/RCTSettingsManager.mm index 8ef43c4394f..b443121ac79 100644 --- a/Libraries/Settings/RCTSettingsManager.mm +++ b/Libraries/Settings/RCTSettingsManager.mm @@ -52,11 +52,6 @@ RCT_EXPORT_MODULE() return self; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - - (facebook::react::ModuleConstants)constantsToExport { return (facebook::react::ModuleConstants)[self getConstants]; diff --git a/Libraries/Text/Text/RCTTextViewManager.m b/Libraries/Text/Text/RCTTextViewManager.m index d3449ee5135..c954809ae6d 100644 --- a/Libraries/Text/Text/RCTTextViewManager.m +++ b/Libraries/Text/Text/RCTTextViewManager.m @@ -50,11 +50,6 @@ RCT_EXPORT_VIEW_PROPERTY(selectable, BOOL) lazilyLoadIfNecessary:YES]]; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - - (UIView *)view { return [RCTTextView new]; diff --git a/Libraries/Text/TextInput/Multiline/RCTUITextView.m b/Libraries/Text/TextInput/Multiline/RCTUITextView.m index a7796f47d90..04ee831bf6a 100644 --- a/Libraries/Text/TextInput/Multiline/RCTUITextView.m +++ b/Libraries/Text/TextInput/Multiline/RCTUITextView.m @@ -51,11 +51,6 @@ static UIColor *defaultPlaceholderColor() return self; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - #pragma mark - Accessibility - (void)setIsAccessibilityElement:(BOOL)isAccessibilityElement diff --git a/Libraries/Text/TextInput/RCTBaseTextInputViewManager.m b/Libraries/Text/TextInput/RCTBaseTextInputViewManager.m index f6e6f2967ef..2b12eedcfd2 100644 --- a/Libraries/Text/TextInput/RCTBaseTextInputViewManager.m +++ b/Libraries/Text/TextInput/RCTBaseTextInputViewManager.m @@ -95,11 +95,6 @@ RCT_EXPORT_SHADOW_PROPERTY(onContentSizeChange, RCTBubblingEventBlock) lazilyLoadIfNecessary:YES]]; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - #pragma mark - RCTUIManagerObserver - (void)uiManagerWillPerformMounting:(__unused RCTUIManager *)uiManager diff --git a/Libraries/Text/TextInput/Singleline/RCTUITextField.m b/Libraries/Text/TextInput/Singleline/RCTUITextField.m index 97add793d1f..ebf704f8183 100644 --- a/Libraries/Text/TextInput/Singleline/RCTUITextField.m +++ b/Libraries/Text/TextInput/Singleline/RCTUITextField.m @@ -32,11 +32,6 @@ return self; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - - (void)_textDidChange { _textWasPasted = NO; diff --git a/RNTester/RNTesterUnitTests/RCTModuleInitNotificationRaceTests.m b/RNTester/RNTesterUnitTests/RCTModuleInitNotificationRaceTests.m index af944929357..781b74bb74a 100644 --- a/RNTester/RNTesterUnitTests/RCTModuleInitNotificationRaceTests.m +++ b/RNTester/RNTesterUnitTests/RCTModuleInitNotificationRaceTests.m @@ -62,11 +62,6 @@ RCT_EXPORT_MODULE() } } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - @end @interface RCTModuleInitNotificationRaceTests : XCTestCase diff --git a/React/Base/RCTRootView.m b/React/Base/RCTRootView.m index cb7f25fef95..5cfc343d0e1 100644 --- a/React/Base/RCTRootView.m +++ b/React/Base/RCTRootView.m @@ -385,7 +385,6 @@ RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)aDecoder) - (void)dealloc { - [[NSNotificationCenter defaultCenter] removeObserver:self]; [_contentView invalidate]; } diff --git a/React/Base/Surface/RCTSurface.mm b/React/Base/Surface/RCTSurface.mm index 75dc8b35dfd..e796bdc6bc2 100644 --- a/React/Base/Surface/RCTSurface.mm +++ b/React/Base/Surface/RCTSurface.mm @@ -106,7 +106,6 @@ - (void)dealloc { [self _stop]; - [[NSNotificationCenter defaultCenter] removeObserver:self]; } #pragma mark - Immutable Properties (no need to enforce synchronization) diff --git a/React/CoreModules/RCTAccessibilityManager.mm b/React/CoreModules/RCTAccessibilityManager.mm index 362c9e9f298..bd25db4ce89 100644 --- a/React/CoreModules/RCTAccessibilityManager.mm +++ b/React/CoreModules/RCTAccessibilityManager.mm @@ -94,11 +94,6 @@ RCT_EXPORT_MODULE() return self; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - - (void)didReceiveNewContentSizeCategory:(NSNotification *)note { self.contentSizeCategory = note.userInfo[UIContentSizeCategoryNewValueKey]; diff --git a/React/CoreModules/RCTDeviceInfo.h b/React/CoreModules/RCTDeviceInfo.h index 3214854b796..cef03bee1be 100644 --- a/React/CoreModules/RCTDeviceInfo.h +++ b/React/CoreModules/RCTDeviceInfo.h @@ -8,8 +8,7 @@ #import #import -#import -@interface RCTDeviceInfo : NSObject +@interface RCTDeviceInfo : NSObject @end diff --git a/React/CoreModules/RCTDeviceInfo.mm b/React/CoreModules/RCTDeviceInfo.mm index 661c5c7d07f..1f9a5ce2d0d 100644 --- a/React/CoreModules/RCTDeviceInfo.mm +++ b/React/CoreModules/RCTDeviceInfo.mm @@ -112,19 +112,6 @@ static NSDictionary *RCTExportedDimensions(RCTBridge *bridge) }; } -- (void)dealloc -{ - [NSNotificationCenter.defaultCenter removeObserver:self]; -} - -- (void)invalidate -{ - RCTExecuteOnMainQueue(^{ - self->_bridge = nil; - [[NSNotificationCenter defaultCenter] removeObserver:self]; - }); -} - - (NSDictionary *)constantsToExport { return [self getConstants]; diff --git a/React/CoreModules/RCTTiming.mm b/React/CoreModules/RCTTiming.mm index 1c6e61047f8..de43d39f04c 100644 --- a/React/CoreModules/RCTTiming.mm +++ b/React/CoreModules/RCTTiming.mm @@ -160,7 +160,6 @@ RCT_EXPORT_MODULE() { [self markEndOfBackgroundTaskIfNeeded]; [_sleepTimer invalidate]; - [[NSNotificationCenter defaultCenter] removeObserver:self]; } - (void)markStartOfBackgroundTaskIfNeeded diff --git a/React/DevSupport/RCTDevLoadingView.m b/React/DevSupport/RCTDevLoadingView.m index 92220b139d1..f2dbd6b3897 100644 --- a/React/DevSupport/RCTDevLoadingView.m +++ b/React/DevSupport/RCTDevLoadingView.m @@ -34,11 +34,6 @@ RCT_EXPORT_MODULE() isEnabled = enabled; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - + (BOOL)requiresMainQueueSetup { return YES; diff --git a/React/DevSupport/RCTDevMenu.m b/React/DevSupport/RCTDevMenu.m index 79733fd0f00..fa8eb65aac6 100644 --- a/React/DevSupport/RCTDevMenu.m +++ b/React/DevSupport/RCTDevMenu.m @@ -157,9 +157,7 @@ RCT_EXPORT_MODULE() { _presentedItems = nil; [_actionSheet dismissViewControllerAnimated:YES - completion:^(void){ - }]; - [[NSNotificationCenter defaultCenter] removeObserver:self]; + completion:^(void){}]; } - (void)showOnShake @@ -425,7 +423,7 @@ RCT_EXPORT_METHOD(show) _presentedItems = items; [RCTPresentedViewController() presentViewController:_actionSheet animated:YES completion:nil]; - + [_bridge enqueueJSCall:@"RCTNativeAppEventEmitter" method:@"emit" args:@[@"RCTDevMenuShown"] diff --git a/React/Fabric/RCTSurfacePresenterBridgeAdapter.mm b/React/Fabric/RCTSurfacePresenterBridgeAdapter.mm index 063731fd151..ffcfc36c1de 100644 --- a/React/Fabric/RCTSurfacePresenterBridgeAdapter.mm +++ b/React/Fabric/RCTSurfacePresenterBridgeAdapter.mm @@ -92,7 +92,6 @@ static RuntimeExecutor RCTRuntimeExecutorFromBridge(RCTBridge *bridge) - (void)dealloc { [_surfacePresenter suspend]; - [self _removeBridgeObservers:_bridge]; } - (RCTBridge *)bridge diff --git a/React/Modules/RCTDevSettings.mm b/React/Modules/RCTDevSettings.mm index eb96d9f3368..728c9bf1812 100644 --- a/React/Modules/RCTDevSettings.mm +++ b/React/Modules/RCTDevSettings.mm @@ -204,7 +204,6 @@ RCT_EXPORT_MODULE() #if ENABLE_PACKAGER_CONNECTION [[RCTPackagerConnection sharedPackagerConnection] removeHandler:_reloadToken]; #endif - [[NSNotificationCenter defaultCenter] removeObserver:self]; } - (NSArray *)supportedEvents diff --git a/React/Modules/RCTRedBox.m b/React/Modules/RCTRedBox.m index 7d0b0516e28..e3fe60900a6 100644 --- a/React/Modules/RCTRedBox.m +++ b/React/Modules/RCTRedBox.m @@ -210,7 +210,6 @@ RCT_NOT_IMPLEMENTED(- (instancetype)initWithCoder:(NSCoder *)aDecoder) { _stackTraceTableView.dataSource = nil; _stackTraceTableView.delegate = nil; - [[NSNotificationCenter defaultCenter] removeObserver:self]; } - (NSString *)stripAnsi:(NSString *)text diff --git a/React/Modules/RCTTVNavigationEventEmitter.m b/React/Modules/RCTTVNavigationEventEmitter.m index 975c6eadc09..8d0ab392e3e 100644 --- a/React/Modules/RCTTVNavigationEventEmitter.m +++ b/React/Modules/RCTTVNavigationEventEmitter.m @@ -32,11 +32,6 @@ RCT_EXPORT_MODULE() return self; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - - (NSArray *)supportedEvents { return @[TVNavigationEventName]; diff --git a/React/Modules/RCTUIManager.m b/React/Modules/RCTUIManager.m index e97a4851c22..53af9041faf 100644 --- a/React/Modules/RCTUIManager.m +++ b/React/Modules/RCTUIManager.m @@ -88,11 +88,6 @@ RCT_EXPORT_MODULE() return NO; } -- (void)dealloc -{ - [NSNotificationCenter.defaultCenter removeObserver:self]; -} - - (void)invalidate { /** @@ -339,9 +334,9 @@ static NSDictionary *deviceOrientationEventBody(UIDeviceOrientation orientation) if (name) { return name; } - + UIView *view = _viewRegistry[reactTag]; - + #pragma clang diagnostic push #pragma clang diagnostic ignored "-Wundeclared-selector" diff --git a/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm b/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm index 26ae685b166..8c0003f179d 100644 --- a/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm +++ b/ReactCommon/turbomodule/core/platform/ios/RCTTurboModuleManager.mm @@ -118,11 +118,6 @@ static Class getFallbackClassFromName(const char *name) return self; } -- (void)dealloc -{ - [[NSNotificationCenter defaultCenter] removeObserver:self]; -} - - (void)notifyAboutTurboModuleSetup:(const char *)name { NSString *moduleName = [[NSString alloc] initWithUTF8String:name];