From dc0106e4f4ace66e54673a3550432a519d582fcf Mon Sep 17 00:00:00 2001 From: Christoph Nakazawa Date: Fri, 31 May 2019 11:08:38 -0700 Subject: [PATCH] Do not send log messages to Metro when `Platform.isTesting` is set Summary: Ideally this should fix `//Libraries/FBReactKit:HiPriServerSnapshotTestsFacebookRedbox`. Reviewed By: PeteTheHeat Differential Revision: D15578792 fbshipit-source-id: 83dd227122170721c0f33c54e0f0e23e810569ae --- Libraries/Core/setUpDeveloperTools.js | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/Libraries/Core/setUpDeveloperTools.js b/Libraries/Core/setUpDeveloperTools.js index da9aa45c50e..43213cb94bb 100644 --- a/Libraries/Core/setUpDeveloperTools.js +++ b/Libraries/Core/setUpDeveloperTools.js @@ -9,6 +9,8 @@ */ 'use strict'; +import Platform from '../Utilities/Platform'; + /** * Sets up developer tools for React Native. * You can use this module directly, or just require InitializeCore. @@ -26,13 +28,15 @@ if (__DEV__) { JSInspector.registerAgent(require('../JSInspector/NetworkAgent')); } - const logToConsole = require('./Devtools/logToConsole'); - ['log', 'warn', 'info', 'trace'].forEach(level => { - const originalFunction = console[level]; - // $FlowFixMe Overwrite console methods - console[level] = function(...args) { - logToConsole(level, args); - originalFunction.apply(console, args); - }; - }); + if (!Platform.isTesting) { + const logToConsole = require('./Devtools/logToConsole'); + ['log', 'warn', 'info', 'trace'].forEach(level => { + const originalFunction = console[level]; + // $FlowFixMe Overwrite console methods + console[level] = function(...args) { + logToConsole(level, args); + originalFunction.apply(console, args); + }; + }); + } }