From dbad0fd607890317614a60ba5a7fcf82c9e5ece1 Mon Sep 17 00:00:00 2001 From: Ramanpreet Nara Date: Tue, 4 Jun 2019 08:25:00 -0700 Subject: [PATCH] Remove TMMDelegate's dependency on ReactApplicationContext Summary: `TurboModuleManagerDelegate` is an interface used to query/create TurboModules. It doesn't need to know anything about `ReactApplicationContext`. So, I'm removing all references of `ReactApplicationContext` from this class. Reviewed By: mdvacca Differential Revision: D15590552 fbshipit-source-id: 761d3ed71f124955f9c6b997e68a7a8338182126 --- .../core/ReactPackageTurboModuleManagerDelegate.java | 2 +- .../turbomodule/core/TurboModuleManagerDelegate.java | 8 +------- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/ReactPackageTurboModuleManagerDelegate.java b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/ReactPackageTurboModuleManagerDelegate.java index fab21c9fca3..839ada2cf08 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/ReactPackageTurboModuleManagerDelegate.java +++ b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/ReactPackageTurboModuleManagerDelegate.java @@ -20,7 +20,7 @@ public abstract class ReactPackageTurboModuleManagerDelegate extends TurboModule private final ReactApplicationContext mReactApplicationContext; public ReactPackageTurboModuleManagerDelegate(ReactApplicationContext reactApplicationContext, List packages) { - super(reactApplicationContext); + super(); mReactApplicationContext = reactApplicationContext; for (ReactPackage reactPackage : packages) { if (reactPackage instanceof TurboReactPackage) { diff --git a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManagerDelegate.java b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManagerDelegate.java index eabeae27640..fda66b65a36 100644 --- a/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManagerDelegate.java +++ b/ReactAndroid/src/main/java/com/facebook/react/turbomodule/core/TurboModuleManagerDelegate.java @@ -20,17 +20,11 @@ public abstract class TurboModuleManagerDelegate { } private final HybridData mHybridData; - private final ReactApplicationContext mReactApplicationContext; protected abstract HybridData initHybrid(); - protected TurboModuleManagerDelegate(ReactApplicationContext rac) { + protected TurboModuleManagerDelegate() { mHybridData = initHybrid(); - mReactApplicationContext = rac; - } - - protected ReactApplicationContext getReactApplicationContext() { - return mReactApplicationContext; } /**