mirror of
https://github.com/facebook/react-native.git
synced 2026-11-18 20:19:07 +00:00
change isPolyfill to type = 'module' | 'script'
Summary: When building, we will process modules in a special way, *not* polyfillys. We will also add more types of (virtual) files that are not modules. That’s why a “type” property makes more sense. Reviewed By: cpojer Differential Revision: D4244583 fbshipit-source-id: 92a0b4a0a2026d0b97ba88034483a6ce4e0c1ebb
This commit is contained in:
1 parent
021b313d88
commit
da079f7433
4 files changed
+11
-9
No files matched your search
+4
-4
@@ -62,16 +62,16 @@ describe('transforming JS modules:', () => {
|
||||
});
|
||||
});
|
||||
|
||||
it('sets `isPolyfill` to `false` by default', done => {
|
||||
it('sets `type` to `"module"` by default', done => {
|
||||
transformModule(sourceCode, options(), (error, result) => {
|
||||
expect(result).toEqual(objectContaining({isPolyfill: false}));
|
||||
expect(result).toEqual(objectContaining({type: 'module'}));
|
||||
done();
|
||||
});
|
||||
});
|
||||
|
||||
it('sets `isPolyfill` to `true` if the input is a polyfill', done => {
|
||||
it('sets `type` to `"script"` if the input is a polyfill', done => {
|
||||
transformModule(sourceCode, {...options(), polyfill: true}, (error, result) => {
|
||||
expect(result).toEqual(objectContaining({isPolyfill: true}));
|
||||
expect(result).toEqual(objectContaining({type: 'script'}));
|
||||
done();
|
||||
});
|
||||
});
|
||||
|
||||
@@ -75,9 +75,9 @@ function transformModule(
|
||||
callback(null, {
|
||||
code,
|
||||
file: filename,
|
||||
isPolyfill: !!options.polyfill,
|
||||
hasteID: annotations.providesModule || annotations.provide || null,
|
||||
transformed,
|
||||
type: options.polyfill ? 'script' : 'module',
|
||||
});
|
||||
});
|
||||
}
|
||||
@@ -105,8 +105,8 @@ function transformJSON(json, options, callback) {
|
||||
code: json,
|
||||
file: filename,
|
||||
hasteID: value.name,
|
||||
isPolyfill: false,
|
||||
transformed,
|
||||
type: 'module',
|
||||
};
|
||||
|
||||
if (basename(filename) === 'package.json') {
|
||||
|
||||
Reference in new issue
Block a user