From d9d2502b612cba72279b036757bf02e0c7dfa67a Mon Sep 17 00:00:00 2001 From: Bartlomiej Bloniarz Date: Wed, 1 Jul 2026 07:13:13 -0700 Subject: [PATCH] Fix AnimatedPropsRegistry surface-stop resurrection race (#57376) Summary: Pull Request resolved: https://github.com/react/react-native/pull/57376 AnimatedPropsRegistry::update() runs on the UI thread every animation frame and created a surface's entry via operator[]. clearOnSurfaceStop() (run on the JS thread when a surface stops) erases that entry, but an in-flight animation frame landing after the stop re-created it via operator[] -- and since the surface is gone, nothing ever cleans it up again. The resurrected entry leaks its PropsSnapshot and ShadowNodeFamily for the lifetime of the registry. A surface's entry is legitimately created by getMap(), which AnimationBackendCommitHook calls on every React commit. stopSurface drains in-flight commits before unregistering the ShadowTree (ShadowTreeRegistry::remove takes the registry's unique lock, which excludes the shared-locked commit visits), so getMap() can never run for a stopped surface. That leaves update()'s operator[] as the only thing that can resurrect one. Fix: update() now only refines surfaces that already exist (find instead of operator[]) and never creates an entry; getMap() remains the sole creator. A stopped surface can no longer be resurrected, and there is no extra bookkeeping that could grow over time. Changelog: [General][Fixed] - Fix a surface-stop race in the C++ Animated shared backend that could permanently leak per-surface animated state Reviewed By: javache Differential Revision: D109156094 fbshipit-source-id: 4684ca51d372023e3b082427a225de7d84d14889 --- .../NativeAnimatedNodesManagerProvider.cpp | 2 +- .../animationbackend/AnimatedPropsRegistry.cpp | 11 ++++++++++- .../animationbackend/AnimatedPropsRegistry.h | 1 + .../animationbackend/AnimationBackend.cpp | 17 +++++++++++++++++ .../react/renderer/scheduler/Scheduler.cpp | 17 +++++++++++------ .../react/renderer/scheduler/Scheduler.h | 5 +++-- .../react/renderer/uimanager/UIManager.cpp | 4 ++-- .../react/renderer/uimanager/UIManager.h | 4 ++-- .../renderer/uimanager/UIManagerDelegate.h | 2 +- .../viewtransition/ViewTransitionModule.cpp | 2 +- .../api-snapshots/ReactAndroidDebugCxx.api | 7 ++++--- .../api-snapshots/ReactAndroidNewarchCxx.api | 7 ++++--- .../api-snapshots/ReactAndroidReleaseCxx.api | 7 ++++--- .../api-snapshots/ReactAppleDebugCxx.api | 7 ++++--- .../api-snapshots/ReactAppleNewarchCxx.api | 7 ++++--- .../api-snapshots/ReactAppleReleaseCxx.api | 7 ++++--- .../api-snapshots/ReactCommonDebugCxx.api | 7 ++++--- .../api-snapshots/ReactCommonNewarchCxx.api | 7 ++++--- .../api-snapshots/ReactCommonReleaseCxx.api | 7 ++++--- 19 files changed, 85 insertions(+), 43 deletions(-) diff --git a/packages/react-native/ReactCommon/react/renderer/animated/NativeAnimatedNodesManagerProvider.cpp b/packages/react-native/ReactCommon/react/renderer/animated/NativeAnimatedNodesManagerProvider.cpp index 26bea6f2d7c..7fe342f04d5 100644 --- a/packages/react-native/ReactCommon/react/renderer/animated/NativeAnimatedNodesManagerProvider.cpp +++ b/packages/react-native/ReactCommon/react/renderer/animated/NativeAnimatedNodesManagerProvider.cpp @@ -119,7 +119,7 @@ NativeAnimatedNodesManagerProvider::getOrCreate( }); // Register on surfaces started in the future - uiManager->setOnSurfaceStartCallback( + uiManager->addOnSurfaceStartCallback( [animatedMountingOverrideDelegate = std::weak_ptr( animatedMountingOverrideDelegate_)]( diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.cpp b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.cpp index 1598269ea78..02fef88041c 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.cpp +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.cpp @@ -15,7 +15,11 @@ void AnimatedPropsRegistry::update( const std::unordered_map& surfaceUpdates) { auto lock = std::lock_guard(mutex_); for (const auto& [surfaceId, updates] : surfaceUpdates) { - auto& surfaceContext = surfaceContexts_[surfaceId]; + auto contextIt = surfaceContexts_.find(surfaceId); + if (contextIt == surfaceContexts_.end()) { + continue; + } + auto& surfaceContext = contextIt->second; auto& pendingMap = surfaceContext.pendingMap; auto& pendingFamilies = surfaceContext.pendingFamilies; @@ -55,6 +59,11 @@ void AnimatedPropsRegistry::update( } } +void AnimatedPropsRegistry::initializeSurface(SurfaceId surfaceId) { + auto lock = std::lock_guard(mutex_); + surfaceContexts_.try_emplace(surfaceId); +} + std::pair< std::unordered_set>&, SnapshotMap&> diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h index fe4b9b62a0d..50cafc8f4b6 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimatedPropsRegistry.h @@ -38,6 +38,7 @@ using SnapshotMap = std::unordered_map>; class AnimatedPropsRegistry { public: void update(const std::unordered_map &surfaceUpdates); + void initializeSurface(SurfaceId surfaceId); void clear(SurfaceId surfaceId); void clearOnSurfaceStop(SurfaceId surfaceId); std::pair> &, SnapshotMap &> getMap(SurfaceId surfaceId); diff --git a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.cpp b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.cpp index 62a8676088c..e38386a9e44 100644 --- a/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.cpp +++ b/packages/react-native/ReactCommon/react/renderer/animationbackend/AnimationBackend.cpp @@ -56,6 +56,23 @@ AnimationBackend::AnimationBackend( commitHook_(*uiManager, animatedPropsRegistry_), uiManager_(std::move(uiManager)) { react_native_assert(uiManager_.expired() == false); + + auto weakAnimatedPropsRegistry = + std::weak_ptr(animatedPropsRegistry_); + auto initializeSurfaceContext = + [weakAnimatedPropsRegistry](const ShadowTree& shadowTree) { + if (auto animatedPropsRegistry = weakAnimatedPropsRegistry.lock()) { + animatedPropsRegistry->initializeSurface(shadowTree.getSurfaceId()); + } + }; + + if (auto lockedUIManager = uiManager_.lock()) { + lockedUIManager->addOnSurfaceStartCallback(initializeSurfaceContext); + lockedUIManager->getShadowTreeRegistry().enumerate( + [&](const ShadowTree& shadowTree, bool& /*stop*/) { + animatedPropsRegistry_->initializeSurface(shadowTree.getSurfaceId()); + }); + } } void AnimationBackend::unpackMutations( diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp index e2a25bba44b..9aba200a839 100644 --- a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp +++ b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.cpp @@ -22,6 +22,7 @@ #include #include #include +#include namespace facebook::react { @@ -459,9 +460,13 @@ void Scheduler::uiManagerDidPromoteReactRevision(const ShadowTree& shadowTree) { } void Scheduler::uiManagerDidStartSurface(const ShadowTree& shadowTree) { - std::shared_lock lock(onSurfaceStartCallbackMutex_); - if (onSurfaceStartCallback_) { - onSurfaceStartCallback_(shadowTree); + std::vector callbacks; + { + std::shared_lock lock(onSurfaceStartCallbackMutex_); + callbacks = onSurfaceStartCallbacks_; + } + for (const auto& callback : callbacks) { + callback(shadowTree); } } @@ -491,10 +496,10 @@ void Scheduler::removeEventListener( } } -void Scheduler::uiManagerShouldSetOnSurfaceStartCallback( +void Scheduler::uiManagerShouldAddOnSurfaceStartCallback( OnSurfaceStartCallback&& callback) { - std::shared_lock lock(onSurfaceStartCallbackMutex_); - onSurfaceStartCallback_ = std::move(callback); + std::unique_lock lock(onSurfaceStartCallbackMutex_); + onSurfaceStartCallbacks_.push_back(std::move(callback)); } } // namespace facebook::react diff --git a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.h b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.h index bd6de832e04..bc0b7b17d80 100644 --- a/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.h +++ b/packages/react-native/ReactCommon/react/renderer/scheduler/Scheduler.h @@ -9,6 +9,7 @@ #include #include +#include #include #include @@ -117,7 +118,7 @@ class Scheduler final : public UIManagerDelegate { void removeEventListener(const std::shared_ptr &listener); #pragma mark - Surface start callback - void uiManagerShouldSetOnSurfaceStartCallback(OnSurfaceStartCallback &&callback) override; + void uiManagerShouldAddOnSurfaceStartCallback(OnSurfaceStartCallback &&callback) override; private: friend class SurfaceHandler; @@ -159,7 +160,7 @@ class Scheduler final : public UIManagerDelegate { std::shared_ptr viewTransitionModule_; mutable std::shared_mutex onSurfaceStartCallbackMutex_; - OnSurfaceStartCallback onSurfaceStartCallback_; + std::vector onSurfaceStartCallbacks_; }; } // namespace facebook::react diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp index 32929b3a471..4240a94ea4c 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.cpp @@ -765,10 +765,10 @@ void UIManager::removeEventListener( } } -void UIManager::setOnSurfaceStartCallback( +void UIManager::addOnSurfaceStartCallback( UIManagerDelegate::OnSurfaceStartCallback&& callback) { if (delegate_ != nullptr) { - delegate_->uiManagerShouldSetOnSurfaceStartCallback(std::move(callback)); + delegate_->uiManagerShouldAddOnSurfaceStartCallback(std::move(callback)); } } diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h index 28b8729e3e0..657d66e2128 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManager.h @@ -223,8 +223,8 @@ class UIManager final : public ShadowTreeDelegate { void removeEventListener(const std::shared_ptr &listener); -#pragma mark - Set on surface start callback - void setOnSurfaceStartCallback(UIManagerDelegate::OnSurfaceStartCallback &&callback); +#pragma mark - Add on surface start callback + void addOnSurfaceStartCallback(UIManagerDelegate::OnSurfaceStartCallback &&callback); private: friend class UIManagerBinding; diff --git a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerDelegate.h b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerDelegate.h index 235b1fe34ea..ef4dd73de76 100644 --- a/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerDelegate.h +++ b/packages/react-native/ReactCommon/react/renderer/uimanager/UIManagerDelegate.h @@ -95,7 +95,7 @@ class UIManagerDelegate { virtual void uiManagerDidPromoteReactRevision(const ShadowTree &shadowTree) = 0; using OnSurfaceStartCallback = std::function; - virtual void uiManagerShouldSetOnSurfaceStartCallback(OnSurfaceStartCallback &&callback) = 0; + virtual void uiManagerShouldAddOnSurfaceStartCallback(OnSurfaceStartCallback &&callback) = 0; // View transition bitmap snapshot capture and application. virtual void uiManagerDidCaptureViewSnapshot(Tag tag, SurfaceId surfaceId) = 0; diff --git a/packages/react-native/ReactCommon/react/renderer/viewtransition/ViewTransitionModule.cpp b/packages/react-native/ReactCommon/react/renderer/viewtransition/ViewTransitionModule.cpp index 672802ed7aa..ae5cda73364 100644 --- a/packages/react-native/ReactCommon/react/renderer/viewtransition/ViewTransitionModule.cpp +++ b/packages/react-native/ReactCommon/react/renderer/viewtransition/ViewTransitionModule.cpp @@ -59,7 +59,7 @@ void ViewTransitionModule::initialize( }); // Register on surfaces started in the future - uiManager_->setOnSurfaceStartCallback( + uiManager_->addOnSurfaceStartCallback( [weakThis](const ShadowTree& shadowTree) { shadowTree.getMountingCoordinator()->setMountingOverrideDelegate( weakThis); diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api index 9a5ce2066c8..a106856ceee 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidDebugCxx.api @@ -1558,6 +1558,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -4501,8 +4502,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -5234,6 +5235,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -5248,7 +5250,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -5319,8 +5320,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; } diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api index ff685621148..955d8d0bf05 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidNewarchCxx.api @@ -1553,6 +1553,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -4321,8 +4322,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -5048,6 +5049,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -5062,7 +5064,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -5133,8 +5134,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; } diff --git a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api index 25e566d2466..9c9545d3b33 100644 --- a/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAndroidReleaseCxx.api @@ -1557,6 +1557,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -4498,8 +4499,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -5225,6 +5226,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -5239,7 +5241,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -5310,8 +5311,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; } diff --git a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api index 14984a9b86d..bb48df3d3c1 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleDebugCxx.api @@ -4142,6 +4142,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -6699,8 +6700,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -7413,6 +7414,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -7427,7 +7429,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -7498,8 +7499,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; } diff --git a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api index ec05c677501..fa79b4f180c 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleNewarchCxx.api @@ -4126,6 +4126,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -6547,8 +6548,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -7255,6 +7256,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -7269,7 +7271,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -7340,8 +7341,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; } diff --git a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api index ca2d1156795..904d47ec78e 100644 --- a/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactAppleReleaseCxx.api @@ -4141,6 +4141,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -6696,8 +6697,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -7404,6 +7405,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -7418,7 +7420,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -7489,8 +7490,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; } diff --git a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api index 4f98056312e..860a8d1cbcf 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonDebugCxx.api @@ -883,6 +883,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -3057,8 +3058,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -3687,6 +3688,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -3701,7 +3703,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -3772,8 +3773,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; } diff --git a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api index 16d1eb0c64a..c4b1e16d807 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonNewarchCxx.api @@ -879,6 +879,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -2917,8 +2918,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -3541,6 +3542,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -3555,7 +3557,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -3626,8 +3627,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; } diff --git a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api index 23e2b116a3f..2abfb9566a3 100644 --- a/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api +++ b/scripts/cxx-api/api-snapshots/ReactCommonReleaseCxx.api @@ -882,6 +882,7 @@ class facebook::react::AnimatedPropsRegistry { public std::pair>&, facebook::react::SnapshotMap&> getMap(facebook::react::SurfaceId surfaceId); public void clear(facebook::react::SurfaceId surfaceId); public void clearOnSurfaceStop(facebook::react::SurfaceId surfaceId); + public void initializeSurface(facebook::react::SurfaceId surfaceId); public void update(const std::unordered_map& surfaceUpdates); } @@ -3054,8 +3055,8 @@ class facebook::react::Scheduler : public facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) override; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) override; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) final; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) final; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) override; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) override; public void addEventListener(std::shared_ptr listener); public void animationTick() const; @@ -3678,6 +3679,7 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public virtual void shadowTreeDidFinishTransaction(std::shared_ptr mountingCoordinator, bool mountSynchronously) const override; public virtual void shadowTreeDidPromoteReactRevision(const facebook::react::ShadowTree& shadowTree) const override; public void addEventListener(std::shared_ptr listener); + public void addOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void animationTick() const; public void appendChild(const std::shared_ptr& parentShadowNode, const std::shared_ptr& childShadowNode) const; public void completeSurface(facebook::react::SurfaceId surfaceId, const std::shared_ptr>>& rootChildren, facebook::react::ShadowTree::CommitOptions commitOptions); @@ -3692,7 +3694,6 @@ class facebook::react::UIManager : public facebook::react::ShadowTreeDelegate { public void setDelegate(facebook::react::UIManagerDelegate* delegate); public void setIsJSResponder(const std::shared_ptr& shadowNode, bool isJSResponder, bool blockNativeResponder) const; public void setNativeAnimatedDelegate(std::weak_ptr delegate); - public void setOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback); public void setSurfaceProps(facebook::react::SurfaceId surfaceId, const std::string& moduleName, const folly::dynamic& props, facebook::react::DisplayMode displayMode) const noexcept; public void setViewTransitionDelegate(facebook::react::UIManagerViewTransitionDelegate* delegate); public void startEmptySurface(facebook::react::ShadowTree::Unique&& shadowTree) const noexcept; @@ -3763,8 +3764,8 @@ class facebook::react::UIManagerDelegate { public virtual void uiManagerDidStartSurface(const facebook::react::ShadowTree& shadowTree) = 0; public virtual void uiManagerDidUpdateShadowTree(const std::unordered_map& tagToProps) = 0; public virtual void uiManagerShouldAddEventListener(std::shared_ptr listener) = 0; + public virtual void uiManagerShouldAddOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldRemoveEventListener(const std::shared_ptr& listener) = 0; - public virtual void uiManagerShouldSetOnSurfaceStartCallback(facebook::react::UIManagerDelegate::OnSurfaceStartCallback&& callback) = 0; public virtual void uiManagerShouldSynchronouslyUpdateViewOnUIThread(facebook::react::Tag tag, const folly::dynamic& props) = 0; public virtual ~UIManagerDelegate() noexcept = default; }