From d99e657e3909ff14cd623d1df7d3d13056fdd851 Mon Sep 17 00:00:00 2001 From: Valentin Shergin Date: Mon, 15 Apr 2019 02:37:02 -0700 Subject: [PATCH] Fixed incorrect opacity behaviour for component on iOS (#24435) Summary: This PR fixes #24229. Seems currently `opacity` props for Text is being applied twice (one for text color and one for the whole view). This PR disables applying the prop to the text. [CATEGORY] [TYPE] - Fixed double applying opacity prop for Text Pull Request resolved: https://github.com/facebook/react-native/pull/24435 Differential Revision: D14932795 Pulled By: cpojer fbshipit-source-id: f9280fc75f788424cb5f1e42d2e79efdb354d645 --- Libraries/Text/Text/RCTTextShadowView.m | 1 + 1 file changed, 1 insertion(+) diff --git a/Libraries/Text/Text/RCTTextShadowView.m b/Libraries/Text/Text/RCTTextShadowView.m index a3b0b59c354..a1243e3243c 100644 --- a/Libraries/Text/Text/RCTTextShadowView.m +++ b/Libraries/Text/Text/RCTTextShadowView.m @@ -46,6 +46,7 @@ // the RCTTextView backgroundColor to be used, without affecting nested Text // components. self.textAttributes.backgroundColor = nil; + self.textAttributes.opacity = NAN; } - (BOOL)isYogaLeafNode