From d93e67d02c472b997ceec79e2c6c700cbb902165 Mon Sep 17 00:00:00 2001 From: David Vacca Date: Thu, 26 Sep 2024 22:02:42 -0700 Subject: [PATCH] Enable Microtasks, ModernRuntimeScheduler and NativeViewConfigsInBridgelessMode by default only for New Architecture (#46683) Summary: Pull Request resolved: https://github.com/facebook/react-native/pull/46683 Enabling these Microtask, ModernRuntimeScheduler and NativeViewConfigsInBridgelessMode in BridgeMode is risky and leads to bugs. In this diff I'm ensuring we only enable these flags when newArchitecture is enabled changelog: [internal] internal Reviewed By: shwanton Differential Revision: D63503519 fbshipit-source-id: 4ef757834b8f7fba595b3394735f4b91335d7c98 --- .../ReactNativeNewArchitectureFeatureFlagsDefaults.kt | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt index 97e20f572a0..985dd7e0777 100644 --- a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt +++ b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/internal/featureflags/ReactNativeNewArchitectureFeatureFlagsDefaults.kt @@ -30,15 +30,17 @@ public open class ReactNativeNewArchitectureFeatureFlagsDefaults( override fun useTurboModuleInterop(): Boolean = newArchitectureEnabled || super.useTurboModuleInterop() - override fun useModernRuntimeScheduler(): Boolean = true + override fun useModernRuntimeScheduler(): Boolean = + newArchitectureEnabled || super.useModernRuntimeScheduler() override fun enableBridgelessArchitecture(): Boolean = newArchitectureEnabled - override fun enableMicrotasks(): Boolean = true + override fun enableMicrotasks(): Boolean = newArchitectureEnabled || super.enableMicrotasks() override fun enableFabricRenderer(): Boolean = newArchitectureEnabled - override fun useNativeViewConfigsInBridgelessMode(): Boolean = true + override fun useNativeViewConfigsInBridgelessMode(): Boolean = + newArchitectureEnabled || super.useNativeViewConfigsInBridgelessMode() override fun useTurboModules(): Boolean = newArchitectureEnabled }